Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 23, 2024

PR description:

Combined backport of #44783 and #44810

From the master version:

Added new option to veto specific run for PCL alignment based on their HLT Menu. Implemented using a new variable veto_HLT_Menu in LSNumberFilter config.
This change was made, since the PCL Alignment triggered an update based on a Lumiscan run (Run 379524, https://cmsoms.cern.ch/cms/runs/report?cms_run=379524).

PR validation:

PR was validated by testing the MilleStep for one nominal run (Run 379530) and the Lumiscan run (Run 379524), using the following command:

cmsDriver.py milleStep \
	     -s ALCA:PromptCalibProdSiPixelAli \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3 \
	     --datatier ALCARECO \
	     --eventcontent ALCARECO \
	     --processName=ReAlCa \
	     -n 100 \
	     --dasquery='file dataset=/StreamExpress/Run2024C-TkAlMinBias-Express-v1/ALCARECO run=379530'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Combined backport of #44783 and #44810 to CMSSW_14_0_X for 2024 data-taking purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@consuegs, @cmsbuild, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@rsreds, @tocheng, @tlampen, @adewit, @yuanchao, @mmusich, @pakhotin this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 23, 2024

backport of #44783

@mmusich
Copy link
Contributor Author

mmusich commented Apr 23, 2024

backport of #44810

@mmusich
Copy link
Contributor Author

mmusich commented Apr 23, 2024

test parameters:

  • workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.3

@mmusich
Copy link
Contributor Author

mmusich commented Apr 23, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bec975/39025/summary.html
COMMIT: bbe179c
CMSSW: CMSSW_14_0_X_2024-04-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44811/39025/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 1001.4

@mmusich
Copy link
Contributor Author

mmusich commented Apr 23, 2024

@cmsbuild, please test with #44815

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bec975/39029/summary.html
COMMIT: bbe179c
CMSSW: CMSSW_14_0_X_2024-04-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44811/39029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319088
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44815

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2024

@cms-sw/orp-l2 can you consider this for the next patch release?

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

@cms-sw/orp-l2 can you consider this for the next patch release?

Yes, it will enter 14_0_6_patch1.

@cmsbuild cmsbuild merged commit 41eaac9 into cms-sw:CMSSW_14_0_X Apr 29, 2024
@mmusich mmusich deleted the mm_dev_followup_PCL_Alignment_HLT_Menu_check_14_0_X branch April 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants