Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 29, 2024

PR description:

Backport of #44682 by @iarspider:

As suggested in #44645 (comment)

Includes the following clean up from #44870.

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #44682 and #44870 to CMSSW 14.0.x to keep the alpaka code consistent.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 29, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 29, 2024

backport #44682

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/TrackSoA (heterogeneous, reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)

@makortel, @cmsbuild, @fwyzard, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@lgray, @hatakeyamak, @rovere, @VinInn, @seemasharmafnal, @VourMa, @JanFSchulte, @missirol, @gpetruc, @mmarionncern, @mtosi, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 29, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 29, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 29, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5232e4/39173/summary.html
COMMIT: 51c270a
CMSSW: CMSSW_14_0_X_2024-04-29-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44871/39173/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5232e4/39173/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5232e4/39173/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432929
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432903
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 501
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39239
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 80b6994 into cms-sw:CMSSW_14_0_X May 1, 2024
@fwyzard fwyzard deleted the no_EventSetup_records_in_device_code_140x branch June 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants