Skip to content

Fix TkAlStyle includes and add unit tests #43650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Jan 12, 2024
Merged

Fix TkAlStyle includes and add unit tests #43650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54fb59
put back some removed functionalities to TkAlStyle
mmusich Jan 3, 2024
1d930f3
fix include statements for TkAlStyle.h (and apply code-format to trac…
mmusich Jan 3, 2024
e3347b7
add a unit test for TkAlStyle
mmusich Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Alignment/OfflineValidation/interface/TkAlStyle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ enum PublicationStatus {
// Data era: determines labels of data-taking periods, e.g. CRUZET
enum Era { NONE, CRUZET15, CRAFT15, COLL0T15 };

// Alignment object
enum AlignObj { IDEALAlign, RUN1Align, CRUZETAlign, CRAFTAlign, Coll0TAlign };

class TkAlStyle {
public:
// Adjusts the gStyle settings and store the PublicationStatus
Expand All @@ -52,6 +55,13 @@ class TkAlStyle {
static void set(const TString customTitle);
static PublicationStatus status() { return publicationStatus_; }

static TString toTString(const PublicationStatus status);
static TString toTString(const Era era);
static TString toTString(const AlignObj obj);

static int color(const AlignObj obj);
static int style(const AlignObj obj);

// Draws a title "<CMS label> 2015" on the current pad
// dependending on the PublicationStatus
// INTERNAL : no extra label (intended for AN-only plots with data)
Expand Down
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/macros/FitPVResiduals.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include <sstream>
#include <string>
#include <vector>
//#include "Alignment/OfflineValidation/macros/TkAlStyle.cc"
//#include "Alignment/OfflineValidation/interface/TkAlStyle.h"
#include "Alignment/OfflineValidation/macros/CMS_lumi.h"
#define PLOTTING_MACRO // to remove message logger
#include "Alignment/OfflineValidation/interface/PVValidationHelpers.h"
Expand Down
Loading