Fix TkAlStyle includes and add unit tests

[mmusich]

PR description:

PR #38304 moved TkAlStyle.cc from Alignment/OfflineValidation/macros to a header / source implementation in order to include the header file in other developments.
This has broken few macros in cmssw that contain the incorrect include: this PR fixes the issue, while adding back some lost functionalities originally included in PR #15570 and removed in the meanwhile.
The file Alignment/OfflineValidation/macros/trackSplitPlot.C has apparently not been touched since the central code-format campaign, and thus in order for this PR to pass the standard code quality requirements, it is now heavily changed (albeit basically all of it is just formatting).
I profit of this PR to add a dedicated unit test profiting of the existing file Alignment/OfflineValidation/test/testTkAlStyle.C.

PR validation:

Relies on the compilation and the newly added unit test (scram b runtests_testTkAlStyle runs fine).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to 13.0.X to be used for the 2022+2023 re-reco alignment campaigns.

[mmusich]

type bug-fix

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43650/38309

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @rsreds, @tocheng, @yuanchao, @tlampen this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c56b1/36702/summary.html
COMMIT: 5947b05
CMSSW: CMSSW_14_0_X_2024-01-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43650/36702/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 96 lines from the logs
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1219
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246036
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Stilish comments are, of course, unimportant: just apply them if you wish.
Please just check my doubts related to L237 and L2329 of trackSplitPlot.C: if you confirm that it is OK I'll sign for AlCa

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

Stilish comments are, of course, unimportant: just apply them if you wish.

since we're not in a hurry with this, I'll implement the comments on the style of the commented lines as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43650/38312

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #43650 was updated. @perrotta, @cmsbuild, @saumyaphor4252, @consuegs can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c56b1/36705/summary.html
COMMIT: e3347b7
CMSSW: CMSSW_14_0_X_2024-01-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43650/36705/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 138 lines to the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1213
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246042
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

there are further developments on top of this PR that are awaiting this to be merged.
@cms-sw/orp-l2 can you please merge it? thank you.

[rappoccio]

+1