Skip to content

[ALCA][DB] Fix copy-constructor warnings reported in DEVEL IBs #43410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Nov 28, 2023
Merged

[ALCA][DB] Fix copy-constructor warnings reported in DEVEL IBs #43410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
187e20a
[ALCA-DB] Fix copy-constructor warnings reported in DEVEL IBs
aandvalenzuela Nov 27, 2023
922429a
apply code format
aandvalenzuela Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions CondFormats/PhysicsToolsObjects/interface/MVAComputer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ namespace PhysicsTools {

class BitSet {
public:
// help that poor ROOT to copy bitsets... (workaround)
BitSet &operator=(const BitSet &other) {
store = other.store;
bitsInLast = other.bitsInLast;
return *this;
}

std::vector<unsigned char> store;
unsigned int bitsInLast;

Expand Down
4 changes: 0 additions & 4 deletions CondFormats/SiStripObjects/interface/SiStripBadStrip.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ class SiStripBadStrip {
typedef Container InputVector;

SiStripBadStrip(){};
SiStripBadStrip(const SiStripBadStrip& orig) {
v_badstrips = orig.v_badstrips;
indexes = orig.indexes;
}
virtual ~SiStripBadStrip(){};

bool put(const uint32_t& detID, const InputVector& vect) { return put(detID, Range(vect.begin(), vect.end())); }
Expand Down
1 change: 0 additions & 1 deletion CondFormats/SiStripObjects/interface/SiStripNoises.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class SiStripNoises {
typedef Registry::const_iterator RegistryIterator;
typedef std::vector<uint16_t> InputVector;

SiStripNoises(const SiStripNoises&);
SiStripNoises() {}
~SiStripNoises() {}

Expand Down
7 changes: 0 additions & 7 deletions CondFormats/SiStripObjects/src/SiStripNoises.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@
#include <iomanip>
#include "CondFormats/SiStripObjects/interface/SiStripDetSummary.h"

SiStripNoises::SiStripNoises(const SiStripNoises& input) {
v_noises.clear();
indexes.clear();
v_noises.insert(v_noises.end(), input.v_noises.begin(), input.v_noises.end());
indexes.insert(indexes.end(), input.indexes.begin(), input.indexes.end());
}

bool SiStripNoises::put(const uint32_t& DetId, const InputVector& input) {
std::vector<unsigned char> Vo_CHAR;
encode(input, Vo_CHAR);
Expand Down