Skip to content

Use ratio timing for CPU algorithm in ECAL CPU vs. GPU validation #43127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Oct 30, 2023
Merged

Use ratio timing for CPU algorithm in ECAL CPU vs. GPU validation #43127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,24 @@
# ECAL multifit running on GPU
from RecoLocalCalo.EcalRecProducers.ecalUncalibRecHitProducerGPU_cfi import ecalUncalibRecHitProducerGPU as _ecalUncalibRecHitProducerGPU
ecalMultiFitUncalibRecHitGPU = _ecalUncalibRecHitProducerGPU.clone(
digisLabelEB = cms.InputTag('ecalDigisGPU', 'ebDigis'),
digisLabelEE = cms.InputTag('ecalDigisGPU', 'eeDigis'),
digisLabelEB = 'ecalDigisGPU:ebDigis',
digisLabelEE = 'ecalDigisGPU:eeDigis',
)

# copy the uncalibrated rechits from GPU to CPU
from RecoLocalCalo.EcalRecProducers.ecalCPUUncalibRecHitProducer_cfi import ecalCPUUncalibRecHitProducer as _ecalCPUUncalibRecHitProducer
ecalMultiFitUncalibRecHitSoA = _ecalCPUUncalibRecHitProducer.clone(
recHitsInLabelEB = cms.InputTag('ecalMultiFitUncalibRecHitGPU', 'EcalUncalibRecHitsEB'),
recHitsInLabelEE = cms.InputTag('ecalMultiFitUncalibRecHitGPU', 'EcalUncalibRecHitsEE'),
recHitsInLabelEB = 'ecalMultiFitUncalibRecHitGPU:EcalUncalibRecHitsEB',
recHitsInLabelEE = 'ecalMultiFitUncalibRecHitGPU:EcalUncalibRecHitsEE',
containsTimingInformation = True
)

# convert the uncalibrated rechits from SoA to legacy format
from RecoLocalCalo.EcalRecProducers.ecalUncalibRecHitConvertGPU2CPUFormat_cfi import ecalUncalibRecHitConvertGPU2CPUFormat as _ecalUncalibRecHitConvertGPU2CPUFormat
gpu.toModify(ecalMultiFitUncalibRecHit,
cuda = _ecalUncalibRecHitConvertGPU2CPUFormat.clone(
recHitsLabelGPUEB = cms.InputTag('ecalMultiFitUncalibRecHitSoA', 'EcalUncalibRecHitsEB'),
recHitsLabelGPUEE = cms.InputTag('ecalMultiFitUncalibRecHitSoA', 'EcalUncalibRecHitsEE'),
recHitsLabelGPUEB = 'ecalMultiFitUncalibRecHitSoA:EcalUncalibRecHitsEB',
recHitsLabelGPUEE = 'ecalMultiFitUncalibRecHitSoA:EcalUncalibRecHitsEE',
)
)

Expand Down
13 changes: 13 additions & 0 deletions RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,16 @@
)
)

# this overrides the modifications made by run3_ecal if both modifiers are active
from Configuration.ProcessModifiers.gpuValidationEcal_cff import gpuValidationEcal
gpuValidationEcal.toModify(ecalMultiFitUncalibRecHit,
algoPSet = dict(timealgo = 'RatioMethod',
outOfTimeThresholdGain12pEB = 5.,
outOfTimeThresholdGain12mEB = 5.,
outOfTimeThresholdGain61pEB = 5.,
outOfTimeThresholdGain61mEB = 5.,
timeCalibTag = ':',
timeOffsetTag = ':'
)
)