Use ratio timing for CPU algorithm in ECAL CPU vs. GPU validation

[thomreis]

PR description:

Since the ECAL time reconstruction on GPU uses the ratio method the CPU algorithm should use the same method for the CPU vs. GPU validation.
In addition, the calculated time information is stored in the legacy collection.

PR validation:

Tested with WF 12434.513 (ECAL GPU validation). The two timing algorithms match and the DQM histograms are filled.

[thomreis]

type ecal

[thomreis]

enable gpu

[thomreis]

test parameters:

• pull_request=Skip EcalRawData collection in ECAL DQM in GPU WFs #43058

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43127/37397

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@wang0jin, @missirol, @youyingli, @argiro, @apsallid, @ReyerBand, @rchatter, @thomreis this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c60630/35450/summary.html
COMMIT: 6befffe
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43127/35450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1897
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 37843
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[thomreis]

Failing GPU tests are expected because of #43058 . Without it the histograms would be empty.

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1