Herwig lhe matching fix 10_6

[Dominic-Stafford]

Backport of #42673 for use in Run 2 UL gen production. These add a new Herwig7HadronizerFilter, designed to resolve the issue of the wrong lhe events being saved with Herwig.

Should be tested with cms-sw/cmsdist#8728

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for CMSSW_10_6_X.

It involves the following packages:

• Configuration/Generator (generators)
• GeneratorInterface/Herwig7Interface (generators)
• GeneratorInterface/LHEInterface (generators)
• SimDataFormats/GeneratorProducts (generators)

@GurpreetSinghChahal, @SiewYan, @menglu21, @alberto-sanchez, @cmsbuild, @mkirsano, @bbilin can you please review it and eventually sign? Thanks.
@apsallid, @Martin-Grunewald, @bsunanda, @alberto-sanchez, @fabiocos, @missirol, @mkirsano, @rovere, @youyingli this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Herwig lhe matching fix (including multithreading fixes) #42673

[antoniovilela]

@Dominic-Stafford @cms-sw/generators-l2
Hello, has this been validated in 10_6? Will we need a new 10_6 release?

[antoniovilela]

please test with cms-sw/cmsdist#8728

[antoniovilela]

backport of #42673

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56be19/35068/summary.html
COMMIT: 6e09ac5
CMSSW: CMSSW_10_6_X_2023-10-01-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42907/35068/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[menglu21]

@Dominic-Stafford @cms-sw/generators-l2 Hello, has this been validated in 10_6? Will we need a new 10_6 release?

Hi, I don't think it's urgent since herwig is not used that much. This can be done in the future when some necessary update needed for 10_6

[Dominic-Stafford]

@Dominic-Stafford @cms-sw/generators-l2 Hello, has this been validated in 10_6? Will we need a new 10_6 release?

Hi, yes, this has been validated in 10_6 in my private tests. It would be nice to have in reasonably soon since it's a reasonably large change to Herwig, but as Meng says Herwig isn't used for so many requests, so it probably doesn't need its own release

[rappoccio]

+1