Skip to content

Conversation

@Dominic-Stafford
Copy link
Contributor

Backport of #8670 for use in Run 2 UL production. Adds patches which propagate an event number provided in an LHE file through Herwig, which is necessary for ensuring the lhe events "line up" with the gen events if some events are skipped in merging.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2023

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_10_6_X/gcc700.

@cmsbuild, @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a885/34968/summary.html
COMMIT: 12d3b49
CMSSW: CMSSW_10_6_X_2023-09-24-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8728/34968/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@rappoccio @antoniovilela , feel free to merge it for next 10.6.X release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

backport of #8670

@smuzaffar smuzaffar changed the title Add patches to propagate lhe numbering through herwig [10.6.X] Add patches to propagate lhe numbering through herwig Sep 29, 2023
@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#42907

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a885/34976/summary.html
COMMIT: 12d3b49
CMSSW: CMSSW_10_6_X_2023-09-24-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8728/34976/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit cc3ddc7 into cms-sw:IB/CMSSW_10_6_X/gcc700 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants