Skip to content

Silence static analyzer warning on existsAs() calls in PluginDescription.h #42889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Oct 2, 2023
Merged

Silence static analyzer warning on existsAs() calls in PluginDescription.h #42889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions FWCore/ParameterSet/interface/PluginDescription.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ namespace edm {
}

bool exists_(ParameterSet const& pset) const final {
return pset.existsAs<std::string>(typeLabel_, typeLabelIsTracked_);
CMS_SA_ALLOW return pset.existsAs<std::string>(typeLabel_, typeLabelIsTracked_);
}

bool partiallyExists_(ParameterSet const& pset) const final { return exists_(pset); }
Expand All @@ -200,9 +200,10 @@ namespace edm {
private:
std::string findType(edm::ParameterSet const& iPSet) const {
if (typeLabelIsTracked_) {
if (iPSet.existsAs<std::string>(typeLabel_) || defaultType_.empty()) {
CMS_SA_ALLOW if (iPSet.existsAs<std::string>(typeLabel_) || defaultType_.empty()) {
return iPSet.getParameter<std::string>(typeLabel_);
} else {
}
else {
return defaultType_;
}
}
Expand Down