-
Notifications
You must be signed in to change notification settings - Fork 4.6k
L1T ZDC and uGT Emulator Backport #42706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T ZDC and uGT Emulator Backport #42706
Conversation
|
A new Pull Request was created by @cfmcginn (Chris) for CMSSW_13_2_X. It involves the following packages:
@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
Backport of #42634 |
|
please test |
|
please abort |
|
please test with cms-data/L1Trigger-L1TCalorimeter#23 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34583/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
test parameters: |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34589/summary.html Comparison SummarySummary:
|
|
urgent |
|
urgent
|
|
+1 |
|
@antoniovilela , please do not forget to integrate the externals PR needed for this ( e.g. in this case cms-sw/cmsdist#8678 should have been integrated at the same time ). Anyway , I have merged cms-sw/cmsdist#8678 now |
The text below is taken from the merged PR to CMSSW_13_3_X, here:
#42634
This is a backport to CMSSW_13_2_X as the release for HI datataking
PR description:
PR for L1Trigger ZDC emulation, for upcoming heavy ions datataking. L1Trigger/L1TZDC pkg added containing L1TZDCProducer which puts ZDC based EtSum into the event, which can be picked up in trigger emulation and cut on as with any other EtSum object. New EtSum IDs are added for ZDCP and ZDCM (plus and minus). Additional PR from @elfontan interfacing this PR w/ the Global trigger has since been incorporate here (PR #42635 , now closed; some of the detail in that PR is now incorporated here as of 2023.08.29). This includes an update of the uGT emulator for new ZDC triggers included in the Heavy Ion menu for the 2023 data-taking. The implementation relies on new developments included in the utm libraries v0_11_0.
The main changes are the following:
The following L1Ntuples workflows are also updated to include the new input tags for ZDC objects:
PR validation:
Emulator output validated against offline ZDC Et Sum calculations ( @hjbossi ) :
ZDCEmulationValidation.pdf
The following suite of tests were done after successful build
All tests passed
Tagging a few additional users to watch this PR: @ginnocen @icali @elfontan @hjbossi