Skip to content

Conversation

@cfmcginn
Copy link
Contributor

@cfmcginn cfmcginn commented Sep 1, 2023

The text below is taken from the merged PR to CMSSW_13_3_X, here:
#42634

This is a backport to CMSSW_13_2_X as the release for HI datataking

PR description:

PR for L1Trigger ZDC emulation, for upcoming heavy ions datataking. L1Trigger/L1TZDC pkg added containing L1TZDCProducer which puts ZDC based EtSum into the event, which can be picked up in trigger emulation and cut on as with any other EtSum object. New EtSum IDs are added for ZDCP and ZDCM (plus and minus). Additional PR from @elfontan interfacing this PR w/ the Global trigger has since been incorporate here (PR #42635 , now closed; some of the detail in that PR is now incorporated here as of 2023.08.29). This includes an update of the uGT emulator for new ZDC triggers included in the Heavy Ion menu for the 2023 data-taking. The implementation relies on new developments included in the utm libraries v0_11_0.

The main changes are the following:

  • The L1Trigger/L1TZDC area containing plugins L1TZDCProducer and L1TZDCAnalyzer, former for producing etSums and the latter primarily used in validation of Produce in comparisons w/ etSums checked offline
  • The TriggerMenuParser is adapted to parse the new ZDCPlus and ZDCMinus conditionTypes from the xml menu. A dedicated parsing function parseZdcEnergySum is included to relate these objects to the new ZdcEnergySumTemplate.
  • The GlobalBoard is updated to receive a new category of objects similar to the EtSum from the CaloLayer2 coming from the new ZDC Producer included in
  • L1T ZDC and uGT Emulator to CMSSW_13_3_X #42634.
  • A dedicated ZdcEnergySumTemplate and a ZdcEnergySumCondition class are developed for checking the EtSum threshold on the ZDC objects.
  • Addition of condZdcEnergySum to avoid conflicts with existing condEnergySum
  • The ste of input tags to the L1TGlobalProducer is updated in simGtStage2Digis_cfi.py.

The following L1Ntuples workflows are also updated to include the new input tags for ZDC objects:

  • L1NtupleEMU_cff.py
  • L1NtupleRAW_cff.py
  • l1UpgradeTree_cfi.py

PR validation:

Emulator output validated against offline ZDC Et Sum calculations ( @hjbossi ) :
ZDCEmulationValidation.pdf

The following suite of tests were done after successful build

scram b runtests
scram build code-checks
scram build code-format

All tests passed

Tagging a few additional users to watch this PR: @ginnocen @icali @elfontan @hjbossi

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

A new Pull Request was created by @cfmcginn (Chris) for CMSSW_13_2_X.

It involves the following packages:

  • DataFormats/L1TGlobal (l1)
  • DataFormats/L1Trigger (l1)
  • L1Trigger/L1TCalorimeter (l1)
  • L1Trigger/L1TGlobal (l1)
  • L1Trigger/L1TNtuples (l1)
  • L1Trigger/L1TZDC (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

Backport of #42634

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2023

please test

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2023

please abort

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2023

please test with cms-data/L1Trigger-L1TCalorimeter#23

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34583/summary.html
COMMIT: 09869e9
CMSSW: CMSSW_13_2_X_2023-09-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42706/34583/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34583/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34583/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197880
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8043c/34589/summary.html
COMMIT: 09869e9
CMSSW: CMSSW_13_2_X_2023-09-03-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42706/34589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197888
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

urgent

@malbouis
Copy link
Contributor

malbouis commented Sep 4, 2023

urgent

  • this is needed for testing HLT menus online

@cmsbuild cmsbuild added the urgent label Sep 4, 2023
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31cffb8 into cms-sw:CMSSW_13_2_X Sep 4, 2023
@smuzaffar
Copy link
Contributor

@antoniovilela , please do not forget to integrate the externals PR needed for this ( e.g. in this case cms-sw/cmsdist#8678 should have been integrated at the same time ). Anyway , I have merged cms-sw/cmsdist#8678 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants