Skip to content

Conversation

@elfontan
Copy link
Contributor

@elfontan elfontan commented Sep 13, 2023

PR description:

Bug fix related to the uGT emulator changes for ZDC triggers (#42634, 132X backport: #42706) in view of the 2023 HI data-taking. Backport of #42778 for the 2023 HI data-taking.

PR validation:

The PR has been prepared starting from CMSSW_13_2_X_2023-09-13-1100:

cmsrel CMSSW_13_2_X_2023-09-13-1100
cd CMSSW_13_2_X_2023-09-13-1100/src
cmsenv
git cms-init
git cms-addpkg L1Trigger/L1TGlobal
scram b && scram b code-checks && scram b code-format && scram b

[cc: @hjbossi @cfmcginn @ginnocen @icali]

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2023

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_13_2_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

urgent

@aloeliger
Copy link
Contributor

backport of #42778

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-663db1/34745/summary.html
COMMIT: 98d5b77
CMSSW: CMSSW_13_2_X_2023-09-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42781/34745/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198168
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198140
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0b08d07 into cms-sw:CMSSW_13_2_X Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants