fix off-by-one error in TauNNIdHW::compute

[dan131riley]

PR description:

There's an off-by-one error in TauNNIdHW::compute where the loop at line 91 continues one place past the end of the arrays. This was spotted in the ASAN builds as part of the testing of #42077.

PR validation:

Verified that, with the inclusion of #42077, this fixes the remaining ASAN errors in WF 20034.0. Purely technical fix.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42233/36247

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5943f2/33646/summary.html
COMMIT: 1f6e9b7
CMSSW: CMSSW_13_2_X_2023-07-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42233/33646/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @andrea21z Update Muon MVA ID model and working points in MiniAOD and NanoAOD #41903

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5943f2/33646/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5943f2/33646/git-merge-result

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 27 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193859
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Tests for ASAN were successfully run in #42077 (comment) together with #42077

[aloeliger]

+l1

[AdrianoDee]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1