Phase2 L1T - Ensure cluster ecal_eta/phi are set when not running CombinedCaloLinker.

[EmyrClement]

PR description:

This PR fixes a bug introduced in #41279, where there is now an excess of Puppi candidates (and jets produced from these) at eta/phi=0. The solution is to ensure variables introduced by the previous PR are always set to something sensible.

The PR to cms-l1t-offline is #1124.

PR validation:

See the local PR for before/after validation.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41697/35569

ERROR: Build errors found during clang-tidy run.

--
L1Trigger/Phase2L1ParticleFlow/src/CaloClusterer.cc:526:19: error: no member named 'ecal_phi' in 'l1tpf_calo::CombinedCluster' [clang-diagnostic-error]
          cluster.ecal_phi = cluster.phi;
          ~~~~~~~ ^
L1Trigger/Phase2L1ParticleFlow/src/CaloClusterer.cc:555:19: error: no member named 'ecal_eta' in 'l1tpf_calo::CombinedCluster'; did you mean 'ecal_et'? [clang-diagnostic-error]
          cluster.ecal_eta = cluster.eta;
                  ^~~~~~~~
                  ecal_et
--
L1Trigger/Phase2L1ParticleFlow/src/CaloClusterer.cc:556:19: error: no member named 'ecal_phi' in 'l1tpf_calo::CombinedCluster' [clang-diagnostic-error]
          cluster.ecal_phi = cluster.phi;
          ~~~~~~~ ^
L1Trigger/Phase2L1ParticleFlow/src/CaloClusterer.cc:616:9: error: no member named 'ecal_eta' in 'l1tpf_calo::CombinedCluster'; did you mean 'ecal_et'? [clang-diagnostic-error]
    dst.ecal_eta = src.eta;
        ^~~~~~~~
        ecal_et
--
L1Trigger/Phase2L1ParticleFlow/src/CaloClusterer.cc:617:9: error: no member named 'ecal_phi' in 'l1tpf_calo::CombinedCluster' [clang-diagnostic-error]
    dst.ecal_phi = src.phi;
    ~~~ ^
Suppressed 552 warnings (552 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41697/35571

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @EmyrClement for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05f264/32673/summary.html
COMMIT: af22bdd
CMSSW: CMSSW_13_2_X_2023-05-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41697/32673/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.031 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3222854
• DQMHistoTests: Total failures: 58
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3222774
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[epalencia]

+l1

[AdrianoDee]

+upgrade

• quick fix, CaloLinking in general seems willl be superseded (see Ensure cluster ecal_eta/phi are set when not running CombinedCaloLinker. cms-l1t-offline/cmssw#1124);
• the differences in the matrix seems to be in accordance with the fix;

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1