[ROOT6] Add legacy header for RooCatType for root update #41737

aandvalenzuela · 2023-05-19T18:30:13Z

This PR adds the legacy header for RooCatType class deprecated as for ROOT 6.22 (See https://root.cern/doc/master/classRooAbsCategory.html).
Fixes compilation error on cms-sw/cmsdist#8505 while looking for a replacement for RooCatType.

cmsbuild · 2023-05-19T18:30:37Z

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for CMSSW_13_2_ROOT6_X.

It involves the following packages:

PhysicsTools/TagAndProbe (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aandvalenzuela · 2023-05-19T18:31:46Z

please test for CMSSW_13_2_ROOT6_X

cmsbuild · 2023-05-19T20:11:36Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-badfaf/32726/summary.html
COMMIT: 9fc96cc
CMSSW: CMSSW_13_2_ROOT6_X_2023-05-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-badfaf/32726/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-badfaf/32726/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

23696.0

----- Begin Fatal Exception 19-May-2023 21:44:21 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrelatorLayer1Producer label='l1tLayer1HGCal'
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/compositeID.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/23696.0_CloseByPGun_CE_E_Front_120um+2026D95
----- End Fatal Exception -------------------------------------------------

23700.0

----- Begin Fatal Exception 19-May-2023 21:45:47 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrelatorLayer1Producer label='l1tLayer1HGCal'
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/compositeID.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/23700.0_CloseByPGun_CE_H_Coarse_Scint+2026D95
----- End Fatal Exception -------------------------------------------------

23634.0

----- Begin Fatal Exception 19-May-2023 21:48:26 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCorrelatorLayer1Producer label='l1tLayer1HGCal'
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/compositeID.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32726/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02785/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_2_ROOT6_X_2023-05-18-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/23634.0_TTbar_14TeV+2026D95
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

aandvalenzuela · 2023-05-21T16:56:32Z

please test for CMSSW_13_2_ROOT6_X

cmsbuild · 2023-05-21T21:22:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-badfaf/32735/summary.html
COMMIT: 9fc96cc
CMSSW: CMSSW_13_2_ROOT6_X_2023-05-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41737/32735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 7 lines to the logs
Reco comparison results: 56 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3221243
DQMHistoTests: Total failures: 2276
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3218945
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-05-22T10:28:59Z

please test

lets test and fix it for default IBs

cmsbuild · 2023-05-22T10:34:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41737/35609

This PR adds an extra 20KB to repository

cmsbuild · 2023-05-22T13:16:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-badfaf/32741/summary.html
COMMIT: 9fc96cc
CMSSW: CMSSW_13_2_X_2023-05-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41737/32741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3221591
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3221562
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-05-22T14:03:41Z

@perrotta @rappoccio can we get this is? This is needed for root 6 master IBs .
The comparison differences are due to message logger.

perrotta · 2023-05-22T14:05:47Z

+1

perrotta · 2023-05-22T14:06:26Z

merge

Add legacy header for RooCatType

9fc96cc

cmsbuild added analysis-pending pending-signatures tests-pending orp-pending labels May 19, 2023

cmsbuild added tests-started and removed tests-pending labels May 19, 2023

cmsbuild added tests-rejected and removed tests-started labels May 19, 2023

aandvalenzuela mentioned this pull request May 20, 2023

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8505

Merged

cmsbuild added tests-started and removed tests-rejected labels May 21, 2023

cmsbuild added tests-approved and removed tests-started labels May 21, 2023

smuzaffar changed the base branch from CMSSW_13_2_ROOT6_X to master May 22, 2023 10:28

cmsbuild added this to the CMSSW_13_2_X milestone May 22, 2023

cmsbuild added the code-checks-pending label May 22, 2023

cmsbuild added code-checks-approved tests-started and removed code-checks-pending tests-approved labels May 22, 2023

cmsbuild removed the tests-started label May 22, 2023

cmsbuild added the tests-approved label May 22, 2023

cmsbuild added orp-approved and removed orp-pending labels May 22, 2023

cmsbuild merged commit 2334fc9 into cms-sw:master May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ROOT6] Add legacy header for RooCatType for root update #41737

[ROOT6] Add legacy header for RooCatType for root update #41737

Uh oh!

aandvalenzuela commented May 19, 2023

Uh oh!

cmsbuild commented May 19, 2023

Uh oh!

aandvalenzuela commented May 19, 2023

Uh oh!

cmsbuild commented May 19, 2023

Uh oh!

aandvalenzuela commented May 21, 2023

Uh oh!

cmsbuild commented May 21, 2023

Uh oh!

smuzaffar commented May 22, 2023

Uh oh!

cmsbuild commented May 22, 2023

Uh oh!

cmsbuild commented May 22, 2023

Uh oh!

smuzaffar commented May 22, 2023

Uh oh!

perrotta commented May 22, 2023

Uh oh!

perrotta commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[ROOT6] Add legacy header for RooCatType for root update #41737

[ROOT6] Add legacy header for RooCatType for root update #41737

Uh oh!

Conversation

aandvalenzuela commented May 19, 2023

Uh oh!

cmsbuild commented May 19, 2023

Uh oh!

aandvalenzuela commented May 19, 2023

Uh oh!

cmsbuild commented May 19, 2023

Unit Tests

RelVals

Uh oh!

aandvalenzuela commented May 21, 2023

Uh oh!

cmsbuild commented May 21, 2023

Comparison Summary

Uh oh!

smuzaffar commented May 22, 2023

Uh oh!

cmsbuild commented May 22, 2023

Uh oh!

cmsbuild commented May 22, 2023

Comparison Summary

Uh oh!

smuzaffar commented May 22, 2023

Uh oh!

perrotta commented May 22, 2023

Uh oh!

perrotta commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants