Add unit test for FEDRawDataCollection format

[wddgit]

PR description:

Add a new unit test for the FEDRawDataCollection data format. This generates a data file containing a FEDRawDataCollection object with known content. Then it reads it. It verifies that when we read it we obtain values that match the known written values for all the data fields in the object. In particular all containers have content so all contained types are also read.

It also reads the old files in the DataFormats/FEDRawData data repository which are listed in the shell script. The plan is that each time the data format of FEDRawDataCollection is modified a file will added.

PR validation:

This only adds a unit test in DataFormats/FEDRawData which passes. It shouldn't affect anything else.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41494/35362

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

• DataFormats/FEDRawData (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

FYI @makortel

[wddgit]

abort test

[wddgit]

please test with https://github.com/cms-data/DataFormats-FEDRawData#1

[makortel]

please test with cms-data/DataFormats-FEDRawData#1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-311e19/32323/summary.html
COMMIT: 18a7933
CMSSW: CMSSW_13_1_X_2023-05-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41494/32323/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @yuanchao Payload Inspector for JetCorrector #41409
• @smuzaffar [DQM] [LLVM14] Apply clang-tidy and clang-format changes #41415
• @mmusich add PileupSummaryInfos_addPileupInfo to SiPixelCalSingleMuonTight output data-tier #41411
• @jking79 Ecal CC timing reconstruction deployment #41353
• @iarspider Disable CondToolsLHCInfoNewPopConTest for non-AMD64 #41455
• @AWildridge Fixed bug. Missing edm::InputTag src default value in fillDescriptions #41372
• @bsunanda Phase2-TB70X Try to make an example to run the setup used for investigating radiation damage studies of HGCal module #41385
• @Dr15Jones Improve thread efficiency of CSCTriggerPrimitivesProducer #41465
• @cms-sw openloops: Fixes for scon and python3 cmsdist#8480

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-311e19/32323/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-311e19/32323/git-merge-result

Comparison Summary

Summary:

• You potentially removed 426 lines from the logs
• Reco comparison results: 26099 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 2990
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3457859
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.023 KiB( 47 files compared)
• DQMHistoSizes: changed ( 4.53 ): 0.023 KiB JetMET/SUSYDQM
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[smorovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• newly added tests succeed