-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix nano aod customize v10 #39621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nano aod customize v10 #39621
Conversation
|
would be better this PR instead of #39620 |
|
140.001 succeeded |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39621/32416
|
|
A new Pull Request was created by @vlimant (vlimant) for master. It involves the following packages:
@swertz, @vlimant, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
11634.15 succeeded |
|
Thank you @vlimant ! |
|
please abort |
|
please test workflow 140.002, 149.134, 140.116, 10224.15, 11634.15, 25202.15 |
|
urgent |
|
please test workflow 140.002, 140.034, 140.116, 10224.15, 11634.15, 25202.15 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cb298/28018/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: @slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+1 |
|
@cms-sw/pdmv-l2 (in particular!) @cms-sw/reconstruction-l2 @cms-sw/upgrade-l2 this PR looks like being able to fix the multitude of relval crashes we had in the last two IBs. Could you please evaluate and sign, if you think so, at your earliest? |
|
+reconstruction |
|
Hi @vlimant I would like to avoid the situation that we run different version of Nano between Data (it seems to me that PR sets it to V10 explicitly) and MC. Thanks. |
|
+Upgrade |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
this mitigate the migration of V10 Nano configuration from an unmaintainable customise to the
-s NANO:PhysicsTools/NanoAOD/V10/nano_cffsyntax in cmsDriver (migration done in #39337PR validation:
the workflow in the matrix that were calling for V10 customise now configure properly