Skip to content

Conversation

@perrotta
Copy link
Contributor

@perrotta perrotta commented Oct 5, 2022

Reverts #39337

See #39337 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39620/32415

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/NanoAOD (xpog)

@perrotta, @rappoccio, @swertz, @vlimant, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Oct 5, 2022

please test workflow 11634.15

@vlimant
Copy link
Contributor

vlimant commented Oct 5, 2022

that workflow in particular is using a customise function for V10 that the original PR is getting rid of.
it is outdated and can be left broken for now. I will add a PR that switches to the right configuration to run V10

@perrotta
Copy link
Contributor Author

perrotta commented Oct 5, 2022

11634.15

there are now many more workflows that fail beyond 11634.15 , see https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_12_6/2022-10-04-2300?selectedArchs=el8_amd64_gcc10&selectedFlavors=X&selectedStatus=failed

I tested that one simply to verify esplicitely that reverting the PR its error does disappear

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc8a93/28007/summary.html
COMMIT: d0e493e
CMSSW: CMSSW_12_6_X_2022-10-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39620/28007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dc8a93/11634.15_TTbar_14TeV+2021_JMENano+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dc8a93/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391103
  • DQMHistoTests: Total failures: 62
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391019
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 76887.64699999998 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 640.710 KiB JetMET/PFCandidates
  • DQMHistoSizes: changed ( 10024.0,... ): 448.898 KiB ParticleFlow/slimmedJetValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 263.359 KiB ParticleFlow/slimmedElectronValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 261.354 KiB ParticleFlow/slimmedMuonValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 239.348 KiB ParticleFlow/slimmedMETValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 239.010 KiB Physics/Top
  • DQMHistoSizes: changed ( 10024.0,... ): 235.113 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10024.0,... ): 198.366 KiB JetMET/MET
  • DQMHistoSizes: changed ( 10024.0,... ): 37.338 KiB ParticleFlow/PFJetResValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 24.309 KiB Tracking/PackedCandidate
  • DQMHistoSizes: changed ( 13234.0 ): ...
  • Checked 207 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

Closing this PR because it is not needed any more, given that the fix #39621 worked as intended

@perrotta perrotta closed this Oct 10, 2022
@perrotta perrotta deleted the revert-39337-v10_v11_decoupling branch October 10, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants