include EGM and L1T tags in mcRun3 and data GTs #38283

It is not a backport but it will be backported to 124X (as soon as PR #38265 is merged) and to 123X (for the inclusion of the EGM tags only, in run3_data_relval and run3_data).

cmsbuild · 2022-06-08T03:23:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38283/30434

This PR adds an extra 12KB to repository

cmsbuild · 2022-06-08T03:23:59Z

A new Pull Request was created by @malbouis for master.

It involves the following packages:

Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

malbouis · 2022-06-08T03:24:05Z

test parameters:

workflows = 136.897, 12034.0, 7.23, 12834.0
pull_request = HLT menu development for 12_4_X (2/N) [12_5_X] #38241

malbouis · 2022-06-08T03:24:26Z

please test

missirol · 2022-06-08T05:48:58Z

@malbouis , thanks for the quick update of the GTs with the new L1T menu.

The new run3_hlt and run3_hlt_relval GTs have IOV differences:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v6/124X_dataRun3_HLT_relval_v1

I note it in case you can (and/or want to) change this (I think HLT tests will pass even with the GTs as they are right now).

cmsbuild · 2022-06-08T07:46:42Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5bd3e/25350/summary.html
COMMIT: 0405d95
CMSSW: CMSSW_12_5_X_2022-06-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38283/25350/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 4046231
DQMHistoTests: Total failures: 309
DQMHistoTests: Total nulls: 130
DQMHistoTests: Total successes: 4045770
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 5747.095999999999 KiB( 53 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 438.834 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): 215.022 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): 111.191 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 11634.0,... ): -54.365 KiB HLT/HIG
DQMHistoSizes: changed ( 11634.0,... ): 22.390 KiB HLT/EGM
DQMHistoSizes: changed ( 11634.0,... ): -13.316 KiB HLT/Exotica
DQMHistoSizes: changed ( 11634.0,... ): -6.582 KiB HLT/Higgs
DQMHistoSizes: changed ( 11634.0,... ): 5.213 KiB HLT/Filters
Checked 226 log files, 45 edm output root files, 54 DQM output files
TriggerResults: found differences in 8 / 53 workflows

tvami · 2022-06-08T12:35:03Z

@cmsbuild , please test

tvami · 2022-06-08T12:35:39Z

---> test test-das-selected-lumis had ERRORS

@qliphy is this a known issue? Is there a github issue to follow? It's definitely not coming from this PR

qliphy · 2022-06-08T12:45:26Z

@tvami probably a glitch, see e.g.
#38147
hopefully a new test will succeed

missirol · 2022-06-08T13:47:12Z

@tvami @malbouis , can we please test this PR without #38241 (see this #38283 (comment))?

In #38241, we are already testing the 2 of them together, and here it would be useful to see the differences induced by this PR alone (to disentangle them from the diffs we get when testing #38241+thisPR).

malbouis · 2022-06-08T14:44:55Z

@tvami @malbouis , can we please test this PR without #38241 (see this #38283 (comment))?

@missirol I think we can, but when I tried it locally yesterday, the relval wfs were failing without PR #38241 .

tvami · 2022-06-08T14:47:22Z

test parameters:
*

cmsbuild · 2022-06-08T16:05:17Z

Pull request #38283 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

tvami · 2022-06-08T21:44:40Z

type egamma

tvami · 2022-06-08T21:49:15Z

type l1t

tvami · 2022-06-08T21:50:15Z

@smuzaffar I tried to do type l1t but that doesnt seem to exists. We frequently have updates from the L1T team, so I think it would be nice to have that label

cmsbuild · 2022-06-08T21:54:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5bd3e/25369/summary.html
COMMIT: 1f257cb
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38283/25369/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5bd3e/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 4049895
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 4049859
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 53 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 226 log files, 45 edm output root files, 54 DQM output files
TriggerResults: no differences found

tvami · 2022-06-08T21:56:42Z

+alca

tests pass, diffs are in MsgLogger and MTD only
PR is according to the PR description
this PR can go in first before HLT menu development for 12_4_X (2/N) [12_5_X] #38241

cmsbuild · 2022-06-08T21:57:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2022-06-09T05:32:01Z

@tvami , ok l1t type/label is available now

perrotta · 2022-06-09T07:01:32Z

@smuzaffar I tried to do type l1t but that doesnt seem to exists. We frequently have updates from the L1T team, so I think it would be nice to have that label

@tvami , I see that @smuzaffar has created the corresponding tag.
However, why not simply "assign" it to L1T, if you want a PR to be reviewed by them?

francescobrivio · 2022-06-09T07:35:24Z

@smuzaffar I tried to do type l1t but that doesnt seem to exists. We frequently have updates from the L1T team, so I think it would be nice to have that label

@tvami , I see that @smuzaffar has created the corresponding tag. However, why not simply "assign" it to L1T, if you want a PR to be reviewed by them?

@perrotta I guess the point here is about the "label" goal: AFAIU its purpose is not to request a signature, just to flag the type of the PR for a better bookkeeping.
And this PR is exactly the case: i.e. the only modfied file is autoCond which is alca domain, but the changes come from L1T tag updates.

tvami · 2022-06-09T11:56:37Z

Exactly as Francesco said

tvami · 2022-06-09T11:56:45Z

type l1t

tvami · 2022-06-09T11:58:15Z

@cms-sw/orp-l2 shall we merge this and #38241 asap so they have some time in the IBs before their backport is merged?

qliphy · 2022-06-09T11:58:27Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Jun 8, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jun 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2022

cmsbuild added the requires-external label Jun 8, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 8, 2022

missirol mentioned this pull request Jun 8, 2022

HLT menu development for 12_4_X (2/N) [12_5_X] #38241

Merged

cmsbuild added tests-rejected and removed tests-started labels Jun 8, 2022

cmsbuild mentioned this pull request Jun 8, 2022

Adding HZZ electron MVA ID #37429

Closed

missirol mentioned this pull request Jun 8, 2022

[12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* #38265

Merged

cmsbuild added tests-started and removed tests-rejected labels Jun 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2022

tvami mentioned this pull request Jun 8, 2022

[12_4_X] Include EGM and L1T tags in mcRun3 and data GTs #38293

Merged

cmsbuild added the egamma label Jun 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 8, 2022

malbouis mentioned this pull request Jun 9, 2022

[123X] Include EGM regression in offline data GTs #38295

Closed

cmsbuild added the l1t label Jun 9, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 9, 2022

cmsbuild merged commit d1a9ec1 into cms-sw:master Jun 9, 2022

cmsbuild mentioned this pull request Jun 9, 2022

New PCL Alignment Threshold object in alignment consumers #38273

Merged

include EGM and L1T tags in mcRun3 and data GTs #38283

include EGM and L1T tags in mcRun3 and data GTs #38283

Uh oh!

Conversation

malbouis commented Jun 8, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

Uh oh!

malbouis commented Jun 8, 2022

Uh oh!

malbouis commented Jun 8, 2022

Uh oh!

missirol commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

Unit Tests

Comparison Summary

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

qliphy commented Jun 8, 2022

Uh oh!

missirol commented Jun 8, 2022

Uh oh!

malbouis commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

Uh oh!

tvami commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

Comparison Summary

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

Uh oh!

smuzaffar commented Jun 9, 2022

Uh oh!

perrotta commented Jun 9, 2022

Uh oh!

francescobrivio commented Jun 9, 2022

Uh oh!

tvami commented Jun 9, 2022

Uh oh!

tvami commented Jun 9, 2022

Uh oh!

tvami commented Jun 9, 2022

Uh oh!

qliphy commented Jun 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

malbouis commented Jun 8, 2022 •

edited

Loading

tvami commented Jun 8, 2022 •

edited

Loading