HLT menu development for `12_4_X` (2/N) [`12_5_X`] #38241

missirol · 2022-06-04T06:55:09Z

PR description:

Development of HLT menus for CMSSW_12_4_X.

This is the PR for the master branch, which will then be backported to 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

CMSHLT-2273: [BPH] Double-electron triggers for R(X)-type analyses (partly integrated)
CMSHLT-2281: [HIG] Update of DijetVBF+2Tau trigger
CMSHLT-2282: [EXO] PFMETNoMu trigger with HF cleaning + low-pT double-photon triggers (partly integrated)
CMSHLT-2284: [HIG] Backup and control triggers for 2Tau+Jet trigger
CMSHLT-2285: [HIG] Control triggers for VBF+2Tau trigger
CMSHLT-2289: [TAU] Update of VBF+2Tau triggers
CMSHLT-2291: [B2G] SingleJet and DiJet Triggers on AK8 jets with softdrop-mass cut
CMSHLT-2306: [TOP] Update of DeepJet WP for HT+6Jet+1BTag trigger
CMSHLT-2308: [BPH] Update of triggers for Tau->3Mu search (amended with respect to #38107)
CMSHLT-2314: [JME] Low-pT single-photon trigger for jet-energy corrections
CMSHLT-2316: [TSG] run Pixel DQM (CPU-vs-GPU) inside the HLT
CMSHLT-2321: [EXO] Backup and monitoring triggers for displaced-dimuon searches
CMSHLT-2324: [TSG] Naming: changed AlCaLumiPixelCounts to AlCaLumiPixelsCounts
CMSHLT-2325: [TRK,AlCa,TSG] Update of DQMOnlineBeamspot EventContent and FEDSelector for TCDS
CMSHLT-2330: [TAU,HIG] Naming: changed "DeepTauIso" label to "DeepTau"
CMSHLT-2333: [EGM,HIG] Naming: removed "NoPixelVeto" label from Diphoton Paths (partly integrated)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2022-06-04T07:00:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38241/30394

This PR adds an extra 856KB to repository

cmsbuild · 2022-06-04T07:01:16Z

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-06-04T07:02:14Z

enable gpu

To better test the update of the DQM path, which only runs on GPU.

missirol · 2022-06-04T07:02:39Z

please test

cmsbuild · 2022-06-04T08:13:39Z

-1

Failed Tests: RelVals RelVals-GPU RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159a0e/25270/summary.html
COMMIT: c8e8a33
CMSSW: CMSSW_12_5_X_2022-06-03-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38241/25270/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

139.001

----- Begin Fatal Exception 04-Jun-2022 09:21:02 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'HLT_IsoMu24_eta2p1_MediumDeepTauPFTauHPS30_L2NN_eta2p1_PFJet75_CrossL1_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sMu18erTau26er2p1Jet70'
Exception Message:

Algorithm L1_Mu18er2p1_Tau26er2p1_Jet70, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_Mu18er2p1_Tau26er2p1_Jet70 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 04-Jun-2022 09:35:11 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_DoubleMediumDeepTauIsoPFTauHPS35_L2NN_eta2p1_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sBigORDoubleTauJet'
Exception Message:

Algorithm L1_DoubleIsoTau26er2p1_Jet70_RmOvlp_dR0p5, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_DoubleIsoTau26er2p1_Jet70_RmOvlp_dR0p5 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

11634.7

----- Begin Fatal Exception 04-Jun-2022 09:35:34 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_DoubleMediumDeepTauIsoPFTauHPS35_L2NN_eta2p1_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sBigORDoubleTauJet'
Exception Message:

Algorithm L1_DoubleIsoTau26er2p1_Jet70_RmOvlp_dR0p5, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_DoubleIsoTau26er2p1_Jet70_RmOvlp_dR0p5 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-GPU

11634.50611634.506_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log
11634.51211634.512_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log
11634.52211634.522_TTbar_14TeV+2021_Patatrack_HCALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_HCALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log

RelVals-INPUT

139.002139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB/step2_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log
139.004139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3/step2_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3.log
139.003139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy/step2_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy.log

Expand to see more relval errors ...

missirol · 2022-06-04T09:02:43Z

The tests failed because the HLT menu now requires the L1T menu L1Menu_Collisions2022_v1_0_1 (or higher), but that is not yet included in the MC and _relval GTs.

This PR (and its backport) will have to wait until the update of those GTs with the latest L1T menu, i.e. L1Menu_Collisions2022_v1_1_0 (see this comment). Alternatively, HLT needs to partly revert CMSHLT-2284, which I would disfavour since the GTs have to be updated in any case.

@elfontan , what is the ETA to request the update of the GTs?

missirol · 2022-06-04T12:05:29Z

hold

See #38241 (comment).

cmsbuild · 2022-06-04T12:05:51Z

Pull request has been put on hold by @missirol
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2022-06-06T08:43:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38241/30405

This PR adds an extra 856KB to repository

cmsbuild · 2022-06-07T17:03:07Z

Pull request #38241 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

missirol · 2022-06-08T05:49:44Z

unhold

L1T-v1_1_0 integrated in GTs in #38283.

missirol · 2022-06-08T05:50:33Z

please test with #38283

cmsbuild · 2022-06-08T09:47:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-159a0e/25351/summary.html
COMMIT: f433870
CMSSW: CMSSW_12_5_X_2022-06-07-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38241/25351/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19864
DQMHistoTests: Total failures: 33
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19831
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3649330
DQMHistoTests: Total failures: 285
DQMHistoTests: Total nulls: 98
DQMHistoTests: Total successes: 3648925
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4310.321999999999 KiB( 49 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 438.834 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): 215.022 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): 111.191 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 11634.0,... ): -54.365 KiB HLT/HIG
DQMHistoSizes: changed ( 11634.0,... ): 22.390 KiB HLT/EGM
DQMHistoSizes: changed ( 11634.0,... ): -13.316 KiB HLT/Exotica
DQMHistoSizes: changed ( 11634.0,... ): -6.582 KiB HLT/Higgs
DQMHistoSizes: changed ( 11634.0,... ): 5.213 KiB HLT/Filters
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: found differences in 6 / 49 workflows

missirol · 2022-06-08T22:23:44Z

+hlt

differences in PR-tests outputs are in line with the updates to the GRun HLT menu
some differences are not fully understood (by me), namely diffs in HLT/SiStrip appearing in wf 11634.911 (DD4hep from xml) and 11634.914 (DDD from DB), but not in 11634.0 (DD4hep from db); the updates in this PR in principle do not modify the outputs of the tracker local reconstruction (double-checked based on diffs in ConfDB); I wonder if part of this difference in SiStrip comes from the fact that that part of the reconstruction runs "on demand", and there were changes to Paths running regional pixel tracking (but then, I would naively expect differences in wf 11634.0 too)
this PR should be merged only after include EGM and L1T tags in mcRun3 and data GTs #38283 (but for the same IB, possibly)

cmsbuild · 2022-06-08T22:24:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

missirol · 2022-06-09T10:17:55Z

As I wrote in #38241 (comment), the differences in HLT/SiStrip for only certain Run-3 wfs leave me a bit puzzled, but I don't think that should stop the integration of these HLT updates.

qliphy · 2022-06-09T11:58:51Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Jun 4, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels Jun 4, 2022

missirol mentioned this pull request Jun 4, 2022

HLT menu development for 12_4_X (2/N) #38242

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 4, 2022

cmsbuild added the hold label Jun 4, 2022

missirol force-pushed the HLTdevelopment124X_for125X branch from c8e8a33 to 4445387 Compare June 6, 2022 08:37

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Jun 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 7, 2022

malbouis mentioned this pull request Jun 8, 2022

include EGM and L1T tags in mcRun3 and data GTs #38283

Merged

cmsbuild removed the hold label Jun 8, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2022

cmsbuild mentioned this pull request Jun 8, 2022

Adding HZZ electron MVA ID #37429

Closed

missirol mentioned this pull request Jun 8, 2022

[12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* #38265

Merged

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jun 8, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 9, 2022

cmsbuild merged commit 2367cb3 into cms-sw:master Jun 9, 2022

missirol deleted the HLTdevelopment124X_for125X branch June 9, 2022 11:59

cmsbuild mentioned this pull request Jun 9, 2022

New PCL Alignment Threshold object in alignment consumers #38273

Merged

missirol changed the title ~~HLT menu development for 12_4_X [12_5_X]~~ HLT menu development for 12_4_X (2/N) [12_5_X] Jun 12, 2022

missirol mentioned this pull request Jun 24, 2022

HLT menu development for 12_4_X (4/N) + migration to 12_4_0 + frozen menu V1.2 for 2022 [12_5_X] #38482

Merged

HLT menu development for 12_4_X (2/N) [12_5_X] #38241

HLT menu development for 12_4_X (2/N) [12_5_X] #38241

Uh oh!

Conversation

missirol commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 4, 2022

RelVals

RelVals-GPU

RelVals-INPUT

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 6, 2022

Uh oh!

cmsbuild commented Jun 7, 2022

Uh oh!

missirol commented Jun 8, 2022

Uh oh!

missirol commented Jun 8, 2022

Uh oh!

cmsbuild commented Jun 8, 2022

GPU Comparison Summary

Comparison Summary

Uh oh!

missirol commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 8, 2022

Uh oh!

missirol commented Jun 9, 2022

Uh oh!

qliphy commented Jun 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HLT menu development for `12_4_X` (2/N) [`12_5_X`] #38241

HLT menu development for `12_4_X` (2/N) [`12_5_X`] #38241

missirol commented Jun 4, 2022 •

edited

Loading

missirol commented Jun 8, 2022 •

edited

Loading