-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Remove unused pixel template records from ESProducers and update global tags #35295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25304
|
|
A new Pull Request was created by @OzAmram (Oz Amram) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
This PR fixes cms-AlCaDB/AlCaTools#21 |
acb21bc to
adcb660
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25321
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25322
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
This is coming from: #35277 |
|
Ok, done. I'll rebase later tonight |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25342
|
|
test parameters:
|
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55142a/18684/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
Tests came back as expected: the 6 differences are in the msg logger and are unrelated to this PR |
|
@malbouis @francescobrivio since I contributed to this PR, I don't think I should sign it for AlCa |
|
+alca
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Sorry. Fixed now |
|
+1 |
Thanks for catching this, I just copy pasted the wrong column I think. Here is the list that should be in the describtions |
Ok I updated the PR description |
This PR for removes the lookup of template records for intermediate magnetic field values from the SiPixelGenError and SiPixelTemplate ESProducers. These records are not currently used and given the labor intensive process required to produce the calibrations, we do not plan on supporting intermediate magnetic field values in the future.
This proposed change was discussed at a recent pixel offline meeting.
The PR also changes the all the GTs in line with the code change. More info in
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4465/1/1.html
The differences in the GTs can be seen here and is only regarding this 4 tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_design_v1/121X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_realistic_v1/121X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_startup_v1/121X_mcRun2_startup_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_design_v1/121X_mcRun2_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_pA_v1/121X_mcRun2_pA_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v2/121X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v2/121X_dataRun2_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v3/121X_dataRun3_HLT_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v4/121X_dataRun3_Express_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v3/121X_dataRun3_Prompt_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_v2/121X_dataRun3_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_design_v1/121X_mc2017_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_v1/121X_mc2017_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_design_v1/121X_upgrade2018_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v5/121X_upgrade2018_realistic_RD_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v2/121X_mcRun3_2021_design_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v3/121X_mcRun3_2021_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v3/121X_mcRun3_2021cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v3/121X_mcRun3_2021_realistic_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v2/121X_mcRun3_2023_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v2/121X_mcRun3_2024_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v7/121X_mcRun4_realistic_v1
We do not expect any changes in output.
Fixes cms-AlCaDB/AlCaTools#21