Skip to content

Conversation

@OzAmram
Copy link
Contributor

@OzAmram OzAmram commented Sep 15, 2021

This PR for removes the lookup of template records for intermediate magnetic field values from the SiPixelGenError and SiPixelTemplate ESProducers. These records are not currently used and given the labor intensive process required to produce the calibrations, we do not plan on supporting intermediate magnetic field values in the future.

This proposed change was discussed at a recent pixel offline meeting.

The PR also changes the all the GTs in line with the code change. More info in
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4465/1/1.html

The differences in the GTs can be seen here and is only regarding this 4 tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_design_v1/121X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_realistic_v1/121X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_startup_v1/121X_mcRun2_startup_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_design_v1/121X_mcRun2_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_pA_v1/121X_mcRun2_pA_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v2/121X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v2/121X_dataRun2_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v3/121X_dataRun3_HLT_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v4/121X_dataRun3_Express_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v3/121X_dataRun3_Prompt_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_v2/121X_dataRun3_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_design_v1/121X_mc2017_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_v1/121X_mc2017_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_design_v1/121X_upgrade2018_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v5/121X_upgrade2018_realistic_RD_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v2/121X_mcRun3_2021_design_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v3/121X_mcRun3_2021_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v3/121X_mcRun3_2021cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v3/121X_mcRun3_2021_realistic_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v2/121X_mcRun3_2023_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v2/121X_mcRun3_2024_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v7/121X_mcRun4_realistic_v1

We do not expect any changes in output.

Fixes cms-AlCaDB/AlCaTools#21

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25304

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

  • CalibTracker/SiPixelESProducers (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

Hi @OzAmram thanks! I've created the GTs and pushed the autoCond file towards your branch in
OzAmram#1

It seems you are not using the latest IB tho, please rebase your branch to something from today or tomorrow. We actually will need #35277 to be merged first

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

This PR fixes cms-AlCaDB/AlCaTools#21

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25321

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #35295 was updated. @yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25322

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

Hi @OzAmram thanks for pulling my commit with the GTs. Please remove [RFC] from the title and add the following to the description:

"The PR also changes the all the GTs in line with the code change. More info in
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4465/1/1.html

The differences in the GTs can be seen here and show only these 4 intermediate B-field template tags
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_design_v1/121X_mcRun1_design_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_realistic_v1/121X_mcRun1_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_startup_v1/121X_mcRun2_startup_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_design_v1/121X_mcRun2_design_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_pA_v1/121X_mcRun2_pA_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v2/121X_dataRun2_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v2/121X_dataRun2_relval_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v3/121X_dataRun3_HLT_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v4/121X_dataRun3_Express_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v3/121X_dataRun3_Prompt_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_v2/121X_dataRun3_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_design_v1/121X_mc2017_design_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_v1/121X_mc2017_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_design_v1/121X_upgrade2018_design_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v5/121X_upgrade2018_realistic_RD_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v2/121X_mcRun3_2021_design_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v3/121X_mcRun3_2021_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v3/121X_mcRun3_2021cosmics_realistic_deco_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v3/121X_mcRun3_2021_realistic_HI_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v2/121X_mcRun3_2023_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v2/121X_mcRun3_2024_realistic_Queue
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v7/121X_mcRun4_realistic_Queue
"

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

Conflicting files: Configuration/AlCa/python/autoCond.py

This is coming from: #35277
I think you'll need to rebase after 11:00 PM CERN time

@OzAmram OzAmram changed the title [RFC] Remove unused pixel template records from ESProducers Remove unused pixel template records from ESProducers and update global tags Sep 16, 2021
@OzAmram
Copy link
Contributor Author

OzAmram commented Sep 16, 2021

Ok, done. I'll rebase later tonight

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35295/25342

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #35295 was updated. @yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

test parameters:

  • workflows = 140.0,200.0,202.0,203.0,204.0,205.0,4001.0,4006.0,4007.0,4008.0,11634.0,12434.0,12834.0,1325.516,50200.0,7.22,145.0,281.0,10424.0,7.21,11224.0,250200.182,11024.2,7.4,12034.0,7.23,159.0,12834.0,7.24

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55142a/18684/summary.html
COMMIT: 737546a
CMSSW: CMSSW_12_1_X_2021-09-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35295/18684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/203.0_H130GGgluonfusion+H130GGgluonfusion+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/204.0_QQH1352T+QQH1352T+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/205.0_ZTT+ZTT+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/4001.0_TTbar+TTbar+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/4006.0_SingleElectronFlatPt1To100+SingleElectronFlatPt1To100+DIGIPU1+RECOPU1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/4007.0_QCD_Pt_30_80_BCtoE_8TeV+QCD_Pt_30_80_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/4008.0_QCD_Pt_80_170_BCtoE_8TeV+QCD_Pt_80_170_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/50200.0_ZEE_13+ZEE_13+DIGIUP15_PU50+RECOUP15_PU50_L1TEgDQM+HARVESTUP15_PU50_L1TEgDQM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-55142a/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 17, 2021

Tests came back as expected: the 6 differences are in the msg logger and are unrelated to this PR

@tvami
Copy link
Contributor

tvami commented Sep 17, 2021

@malbouis @francescobrivio since I contributed to this PR, I don't think I should sign it for AlCa

@francescobrivio
Copy link
Contributor

francescobrivio commented Sep 17, 2021

+alca

  • @OzAmram the link to the "recent pixel offline meeting" in the description is not really point to a meeting, please fix it
  • In the description usually we put the difference between the old and the new GT, not between the new GT and the Queue which changes with time...@tvami any particular reason to do that? Maybe we should update the links.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@OzAmram
Copy link
Contributor Author

OzAmram commented Sep 17, 2021

  • @OzAmram the link to the "recent pixel offline meeting" in the description is not really point to a meeting, please fix it

Sorry. Fixed now

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit acf1c33 into cms-sw:master Sep 17, 2021
@tvami
Copy link
Contributor

tvami commented Sep 17, 2021

  • In the description usually we put the difference between the old and the new GT, not between the new GT and the Queue which changes with time...@tvami any particular reason to do that? Maybe we should update the links.

Thanks for catching this, I just copy pasted the wrong column I think. Here is the list that should be in the describtions

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_design_v1/121X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_realistic_v1/121X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_startup_v1/121X_mcRun2_startup_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_design_v1/121X_mcRun2_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_pA_v1/121X_mcRun2_pA_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v2/121X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v2/121X_dataRun2_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v3/121X_dataRun3_HLT_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v4/121X_dataRun3_Express_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v3/121X_dataRun3_Prompt_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_v2/121X_dataRun3_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_design_v1/121X_mc2017_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_v1/121X_mc2017_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_design_v1/121X_upgrade2018_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v5/121X_upgrade2018_realistic_RD_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v2/121X_mcRun3_2021_design_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v3/121X_mcRun3_2021_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v3/121X_mcRun3_2021cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v3/121X_mcRun3_2021_realistic_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v2/121X_mcRun3_2023_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v2/121X_mcRun3_2024_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v7/121X_mcRun4_realistic_v1

@OzAmram
Copy link
Contributor Author

OzAmram commented Sep 17, 2021

  • In the description usually we put the difference between the old and the new GT, not between the new GT and the Queue which changes with time...@tvami any particular reason to do that? Maybe we should update the links.

Thanks for catching this, I just copy pasted the wrong column I think. Here is the list that should be in the describtions

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_design_v1/121X_mcRun1_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_realistic_v1/121X_mcRun1_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_startup_v1/121X_mcRun2_startup_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_design_v1/121X_mcRun2_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun2_pA_v1/121X_mcRun2_pA_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_v2/121X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_relval_v2/121X_dataRun2_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v3/121X_dataRun3_HLT_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v4/121X_dataRun3_Express_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v3/121X_dataRun3_Prompt_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_v2/121X_dataRun3_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_design_v1/121X_mc2017_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_v1/121X_mc2017_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_design_v1/121X_upgrade2018_design_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v5/121X_upgrade2018_realistic_RD_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v2/121X_mcRun3_2021_design_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v3/121X_mcRun3_2021_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v3/121X_mcRun3_2021cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v3/121X_mcRun3_2021_realistic_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v2/121X_mcRun3_2023_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v2/121X_mcRun3_2024_realistic_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v7/121X_mcRun4_realistic_v1

Ok I updated the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove intermediate B field SiPixelTemplates

5 participants