Skip to content

Conversation

@guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #34809).

In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_1_0_pre2.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35215/25161

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • CalibMuon/DTDigiSync (alca)
  • DQM/Physics (dqm)
  • DataFormats/L1THGCal (upgrade, l1)
  • FastSimulation/Utilities (fastsim)
  • L1Trigger/L1THGCal (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • RecoLocalTracker/SiPixelDigiReProducers (reconstruction)
  • RecoMuon/GlobalMuonProducer (reconstruction)
  • SimCalorimetry/HcalZeroSuppressionProducers (simulation)
  • SimG4CMS/EcalTestBeam (simulation)
  • SimG4CMS/FP420 (simulation)
  • SimG4CMS/Forward (simulation)
  • SimG4CMS/ShowerLibraryProducer (simulation)
  • SimGeneral/TrackingAnalysis (simulation)
  • SimMuon/MCTruth (simulation)
  • SimTracker/TrackAssociation (simulation)

@andrius-k, @lveldere, @slava77, @rekovic, @cecilecaillol, @civanch, @yuanchao, @ErnestaP, @ahmad3213, @cmsbuild, @mdhildreth, @AdrianoDee, @jfernan2, @sbein, @jpata, @francescobrivio, @malbouis, @ssekmen, @kmaeshima, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @felicepantaleo, @abbiendi, @argiro, @Martin-Grunewald, @bsunanda, @jbsauvan, @thomreis, @lgray, @threus, @slomeo, @battibass, @abdoulline, @JanFSchulte, @jhgoh, @dgulhan, @sscruz, @cericeci, @simonepigazzini, @trocino, @rociovilar, @cvuosalo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @mmusich, @mtosi, @fabiocos, @HuguesBrun, @rchatter, @Fedespring, @calderona, @gpetruc, @matt-komm, @amarini this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Sep 9, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6e688/18454/summary.html
COMMIT: 61e040f
CMSSW: CMSSW_12_1_X_2021-09-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35215/18454/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 9, 2021

+alca

@civanch
Copy link
Contributor

civanch commented Sep 9, 2021

+1

@srimanob
Copy link
Contributor

+Upgrade

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2021

+reconstruction

for #35215 61e040f

  • technical, in line with the PR description
  • jenkins tests pass

@guitargeek
Copy link
Contributor Author

@cms-sw/l1-l2, this PR is okay for you?

@rekovic
Copy link
Contributor

rekovic commented Sep 14, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants