Changing the proton propagator to the Optical Function method #33405

mundim · 2021-04-12T01:29:39Z

PR description:

Simple change in the configuration file to use the approximate optical function for Run3 instead of the HECTOR (which uses ideal optics from LHC). It needs the record LHCInfoRcd and CTPPSOpticsRcd, which are in process of being integrated into the GT

PR validation:

All standard test has been done: scram b runtests, scram b code-checks and scram b code-formats

The runTheMatrix -l limited -i all --ibeos ran without any error with the official GT, but in this case, since the record below is not in any official GT, an ESSource has been provided on config.

Then the essource was removed and runTheMatrix was tested with the GT 113X_mcRun3_2021_realistic_Candidate_2021_04_06_19_59_53 with no error, however, the correct GT should be 113X_mcRun3_2021_realistic_Candidate_2021_04_09_15_03_03 (14TeV scenario), in which case, there was some wf that failed, however, the wf that runs PPS works fine (the GT above was proposed to solve the problem of #33266 )

In summary: this PR needs the GT 113X_mcRun3_2021_realistic_Candidate_2021_04_09_15_03_03 to be integrated.

cmsbuild · 2021-04-12T01:37:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33405/22034

This PR adds an extra 16KB to repository

cmsbuild · 2021-04-12T01:37:35Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

SimPPS/Configuration
SimTransport/PPSProtonTransport

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2021-04-12T16:05:19Z

please test

cmsbuild · 2021-04-12T17:15:23Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94e1f6/14189/summary.html
COMMIT: 94ed391
CMSSW: CMSSW_11_3_X_2021-04-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33405/14189/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.0

----- Begin Fatal Exception 12-Apr-2021 18:34:47 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 12-Apr-2021 18:35:16 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

11634.911

----- Begin Fatal Exception 12-Apr-2021 18:36:07 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

11834.9911834.99_TTbar_14TeV+2021PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2021PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log
12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log
13034.9913034.99_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 12-Apr-2021 18:21:03 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 1
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_PRef

----- Begin Fatal Exception 12-Apr-2021 18:21:24 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 12-Apr-2021 18:21:55 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_mc_PIon

mundim · 2021-04-12T19:56:25Z

This looks strange to me LHCInfoRcd tag is indeed included in the GT candidate I mentioned above as well as in the last official GT (apparently, according got the dbcond browser). I tested right now the wf 11634.0,12434.0 and it worked, but not the 11634.911 with the same message of missing LHCInfoRcd source. I ran the code locally and it indeed finds the record with no problem.
CORRECTION: IT IS NOT IN THE OFFICIAL GT.

mundim · 2021-04-15T20:22:59Z

Hello
I checked again using the latest IB (CMSSW_11_3_X_2021-04-15-1100) in which all needed tags are included, and all runTheMatrix tests ran without any problem. Is is possible to have this PR integrated into CMSSW_11_3_0?
Thanks

…w GT

cmsbuild · 2021-04-20T02:19:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33405/22183

This PR adds an extra 20KB to repository

cmsbuild · 2021-04-20T02:19:47Z

Pull request #33405 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

civanch · 2021-04-20T08:07:22Z

please test

civanch · 2021-04-20T08:08:38Z

@mundim , this PR will be tested against master - 12_0_X now. If will be accepted it will be possible to discuss backport to 11_3_0.

cmsbuild · 2021-04-20T11:41:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94e1f6/14344/summary.html
COMMIT: b09dcbf
CMSSW: CMSSW_12_0_X_2021-04-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33405/14344/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2877023
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

mundim · 2021-04-20T12:40:12Z

@mundim , this PR will be tested against master - 12_0_X now. If will be accepted it will be possible to discuss backport to 11_3_0.

@civanch, yes, that would be great. Is it automatically queued for back port or do I have to submit a special request?

civanch · 2021-04-20T13:37:00Z

+1

cmsbuild · 2021-04-20T13:37:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

civanch · 2021-04-20T13:37:53Z

@mundim , you need making a separate PR to 11_3_X branch - you may copy files from this PR.

mundim · 2021-04-20T14:00:51Z

@mundim , you need making a separate PR to 11_3_X branch - you may copy files from this PR.

Hi @civanch, I'm afraid I'm not sure about what this means, since this branch was created under 11_3_X one.

silviodonato · 2021-04-20T15:48:03Z

please test workflows 11725.0, 11925.0

silviodonato · 2021-04-20T15:48:17Z

cc @cms-sw/ctpps-dpg-l2

cmsbuild · 2021-04-20T18:36:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94e1f6/14358/summary.html
COMMIT: b09dcbf
CMSSW: CMSSW_12_0_X_2021-04-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33405/14358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-94e1f6/11725.0_GluGluTo2Jets_14TeV+2021+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-94e1f6/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2877017
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

silviodonato · 2021-04-21T08:11:46Z

+1

Changing the proton propagator to the Optical Function method

94ed391

cmsbuild added this to the CMSSW_11_3_X milestone Apr 12, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 12, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2021

cmsbuild added tests-rejected and removed tests-started labels Apr 12, 2021

cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021

Minor changes in the configs removing uneeded loads in view of the ne…

b09dcbf

…w GT

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Apr 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 20, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 20, 2021

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Apr 20, 2021

cmsbuild added tests-started and removed tests-approved labels Apr 20, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 21, 2021

cmsbuild merged commit 8385c0c into cms-sw:master Apr 21, 2021

mundim mentioned this pull request May 3, 2021

Opt fcn prop 4 113 #33613

Closed

Changing the proton propagator to the Optical Function method #33405

Changing the proton propagator to the Optical Function method #33405

Uh oh!

Conversation

mundim commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Apr 12, 2021

Uh oh!

cmsbuild commented Apr 12, 2021

Uh oh!

civanch commented Apr 12, 2021

Uh oh!

cmsbuild commented Apr 12, 2021

RelVals

RelVals-INPUT

AddOn Tests

Uh oh!

mundim commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mundim commented Apr 15, 2021

Uh oh!

cmsbuild commented Apr 20, 2021

Uh oh!

cmsbuild commented Apr 20, 2021

Uh oh!

civanch commented Apr 20, 2021

Uh oh!

civanch commented Apr 20, 2021

Uh oh!

cmsbuild commented Apr 20, 2021

Comparison Summary

Uh oh!

mundim commented Apr 20, 2021

Uh oh!

civanch commented Apr 20, 2021

Uh oh!

cmsbuild commented Apr 20, 2021

Uh oh!

civanch commented Apr 20, 2021

Uh oh!

mundim commented Apr 20, 2021

Uh oh!

silviodonato commented Apr 20, 2021

Uh oh!

silviodonato commented Apr 20, 2021

Uh oh!

cmsbuild commented Apr 20, 2021

Comparison Summary

Uh oh!

silviodonato commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mundim commented Apr 12, 2021 •

edited

Loading

mundim commented Apr 12, 2021 •

edited

Loading