Opt fcn prop 4 113 #33613
Closed
Opt fcn prop 4 113 #33613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix indentation in EDAlias python dump
…omSimClustersProducer_11_3_X_2021-03-30-2300 [HGCAL] TICL SimTracksters - backport 11_3_X
Run3-gex70 Backport 2 PR's cms-sw#33423 and cms-sw#33424 to update 2021, 2026 scenarios
TkDQM: backport of PR 33430
…Algos_113 Fix unit test in PhysicsTools/UtilAlgos (11_3_X)
Run3-gee71x Correct EB geometry and numbering scheme (backport cms-sw#33339 and cms-sw#33471)
…leweights_11_3_X Add ECAL TPG double weight tags and remove GEMELMapRcd from GTs [11_3_X]
All daughter decay filter
Autodetect if a GPU can be used with CMSSW (11.3.x)
…opagation in 113X release
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33613/22452
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Contributor
Author
|
Sorry. the PR was issued without important comments. |
Contributor
|
-1 apparently the target branch is wrong (or the topic branch is just outdated) |
Contributor
|
@mundim please open a new PR starting from a release based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Change the PPS proton propagation from HECTOR to the official/recommended method using optical functions saved in the condDB.
PR validation:
scram b code-checks
scram b code-format
scram b runtests
run with no issues
runTheMatrix.py --job-reports -l limited -i all --ibeos --→ no problems
runTheMatrix.py --job-reports -i all --ibeos -l 11725.0,11925.0 -→ no problems
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport from #33405. The proton propagation using the approximate optical functions is needed in order to produce any simulation that could be compared to foreseen results.