Skip to content

Clean BuildFiles in GeneratorInterface etc #32030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Nov 9, 2020
Merged

Clean BuildFiles in GeneratorInterface etc #32030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions GeneratorInterface/GenExtensions/bin/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<library file="BCVEGPY/*.F,BCVEGPY/*.f" name="GeneratorInterfaceBCVEGPY">
<use name="GeneratorInterface/Pythia6Interface"/>
<use name="pythia6"/>
<use name="f77compiler"/>
</library>

<bin file="BCVEGPY/main.cc" name="BcGenerator">
<use name="GeneratorInterface/Pythia6Interface"/>
<use name="pythia6"/>
<use name="f77compiler"/>
<lib name="GeneratorInterfaceBCVEGPY"/>
</bin>
2 changes: 1 addition & 1 deletion GeneratorInterface/GenFilters/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<use name="FWCore/Framework"/>
<use name="FWCore/Utilities"/>
<use name="SimDataFormats/GeneratorProducts"/>
<use name="GeneratorInterface/Pythia6Interface"/>
<use name="GeneratorInterface/Core"/>
<use name="SimGeneral/HepPDTRecord"/>
<use name="DataFormats/GeometryVector"/>
Expand All @@ -25,6 +24,7 @@
<use name="heppdt"/>
<use name="clhep"/>
<use name="rootcore"/>
<use name="pythia6"/>
<use name="pythia8"/>
<flags EDM_PLUGIN="1"/>
</library>
1 change: 0 additions & 1 deletion RecoEgamma/EgammaIsolationAlgos/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<use name="DataFormats/HcalDetId"/>
<use name="DataFormats/PatCandidates"/>
<use name="CondFormats/HcalObjects"/>
<use name="CondFormats/DataRecord"/>
<use name="RecoLocalCalo/EcalRecAlgos"/>
<use name="CommonTools/Statistics"/>
<export>
Expand Down
1 change: 0 additions & 1 deletion RecoLocalTracker/SiPhase2VectorHitBuilder/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<use name="FWCore/ParameterSet"/>
<use name="FWCore/Framework"/>
<use name="FWCore/Utilities"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="Geometry/CommonDetUnit"/>
<use name="Geometry/TrackerGeometryBuilder"/>
Expand Down
11 changes: 5 additions & 6 deletions RecoLocalTracker/SiPhase2VectorHitBuilder/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@
<use name="root"/>
<use name="classlib"/>
<use name="clhep"/>
<use name="SimDataFormats/TrackingHit"/>
<use name="SimDataFormats/Track"/>
<use name="SimDataFormats/TrackerDigiSimLink"/>
<use name="SimDataFormats/CrossingFrame"/>
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="SimDataFormats/TrackingHit"/>
<use name="SimDataFormats/Vertex"/>
<use name="SimTracker/TrackerHitAssociation"/>
<use name="DataFormats/SiPixelDigi"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/DetId"/>
Expand All @@ -14,13 +17,9 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="CommonTools/UtilAlgos"/>
<use name="DQMServices/Core"/>
<use name="DataFormats/Common"/>
<use name="FWCore/PluginManager"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="DataFormats/Phase2TrackerCluster"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/ParticleFlowReco"/>
<use name="RecoLocalTracker/SiPhase2VectorHitBuilder"/>
<library file="VectorHitsBuilderValidation.cc" name="VectorHitsBuilderValidation">
<flags EDM_PLUGIN="1"/>
Expand Down
1 change: 0 additions & 1 deletion RecoTracker/MeasurementDet/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,3 @@
<use name="RecoLocalTracker/Phase2TrackerRecHits"/>
<use name="TrackingTools/DetLayers"/>
<use name="TrackingTools/MeasurementDet"/>
<use name="RecoLocalTracker/SiPhase2VectorHitBuilder"/>
Copy link
Contributor

@slava77 slava77 Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following files are using this package in the /plugins:

MeasurementTrackerESProducer.cc:#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"
TkStackMeasurementDet.cc:#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"
TkStackMeasurementDet.h:#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"

however there is no explicit or implicit dependence on it in the RecoTracker/MeasurementDet/plugins/BuildFile.xml

IIUC, header-only dependencies are not required in BuildFile.
Incidentally, here, the file include is apparently not needed at all.

Please update the files listed above to drop the #include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h" so that we have a more consistent and cleaner build file setup

1 change: 0 additions & 1 deletion RecoTracker/MeasurementDet/plugins/MeasurementTrackerESProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "RecoLocalTracker/ClusterParameterEstimator/interface/PixelClusterParameterEstimator.h"
#include "RecoLocalTracker/Phase2TrackerRecHits/interface/Phase2StripCPE.h"
#include "RecoLocalTracker/SiStripRecHitConverter/interface/SiStripRecHitMatcher.h"
#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"
#include "Geometry/TrackerGeometryBuilder/interface/TrackerGeometry.h"
#include "RecoTracker/TkDetLayers/interface/GeometricSearchTracker.h"
#include "RecoTracker/Record/interface/CkfComponentsRecord.h"
Expand Down
1 change: 0 additions & 1 deletion RecoTracker/MeasurementDet/plugins/TkStackMeasurementDet.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include "TkStackMeasurementDet.h"

#include "TrackingTools/MeasurementDet/interface/MeasurementDetException.h"
#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"

using namespace std;

Expand Down
1 change: 0 additions & 1 deletion RecoTracker/MeasurementDet/plugins/TkStackMeasurementDet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "TkPhase2OTMeasurementDet.h"

#include "Geometry/CommonDetUnit/interface/StackGeomDet.h"
#include "RecoLocalTracker/SiPhase2VectorHitBuilder/interface/VectorHitBuilderAlgorithm.h"
#include "RecoLocalTracker/ClusterParameterEstimator/interface/PixelClusterParameterEstimator.h"

#include "FWCore/Utilities/interface/Visibility.h"
Expand Down
1 change: 0 additions & 1 deletion SimG4CMS/Muon/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/PluginManager"/>
<use name="SimDataFormats/TrackingHit"/>

<library file="*.cc" name="SimG4CMSMuonTest">
Expand Down