Skip to content

Conversation

@guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #31912).

This PR primarily targets some unused dependencies that have been in the GeneratorInterface subsystem for a long time but also considers some files in other areas that have recently changed and introduced new unused dependencies.

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32030/19579

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

GeneratorInterface/GenExtensions
GeneratorInterface/GenFilters
RecoEgamma/EgammaIsolationAlgos
RecoLocalTracker/SiPhase2VectorHitBuilder
RecoTracker/MeasurementDet
SimG4CMS/Muon

@SiewYan, @perrotta, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @jpata, @agrohsje, @kpedro88, @slava77, @alberto-sanchez, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @alberto-sanchez, @threus, @varuns23, @dgulhan, @makortel, @JanFSchulte, @lgray, @slomeo, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @ebrondol, @mtosi, @fabiocos, @mkirsano, @sobhatta, @afiqaize, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 4, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

+1
Tested at: 8616ba2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-840176/10518/summary.html
CMSSW: CMSSW_11_2_X_2020-11-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-840176/10518/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@agrohsje
Copy link

agrohsje commented Nov 5, 2020

+1

@civanch
Copy link
Contributor

civanch commented Nov 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

+1
Tested at: 508ea03
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-840176/10549/summary.html
CMSSW: CMSSW_11_2_X_2020-11-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-840176/10549/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544121
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 6, 2020

+1

for #32030 508ea03

  • technical; in line with the PR description and the follow up review
  • jenkins tests pass

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 6, 2020

+upgrade

@civanch
Copy link
Contributor

civanch commented Nov 7, 2020

+1

@silviodonato
Copy link
Contributor

do you have any comments @cms-sw/generators-l2 ?

@guitargeek
Copy link
Contributor Author

I don't think they had. @agrohsje signed off this PR before and with the last commit nothing in the gen subsystem has changed.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7a400bc into cms-sw:master Nov 9, 2020
@agrohsje
Copy link

agrohsje commented Nov 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@guitargeek guitargeek deleted the deps_2 branch November 9, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants