-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Clean BuildFiles in GeneratorInterface etc #32030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32030/19579
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: GeneratorInterface/GenExtensions @SiewYan, @perrotta, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @jpata, @agrohsje, @kpedro88, @slava77, @alberto-sanchez, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
+1 |
|
do you have any comments @cms-sw/generators-l2 ? |
|
I don't think they had. @agrohsje signed off this PR before and with the last commit nothing in the gen subsystem has changed. |
|
merge |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Another quick BuildFile cleaning PR in the style of many before (for example #31912).
This PR primarily targets some unused dependencies that have been in the GeneratorInterface subsystem for a long time but also considers some files in other areas that have recently changed and introduced new unused dependencies.
As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.
PR validation:
CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with
git grep.