Skip to content

add missing includes #31932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Oct 28, 2020
Merged

add missing includes #31932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c3a719
add missing includes
davidlange6 Oct 24, 2020
c1f32cc
improve buildfile layout
davidlange6 Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DataFormats/CaloRecHit/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<use name="DataFormats/Math"/>
<use name="DataFormats/DetId"/>
<use name="rootmath"/>
<use name="eigen"/>
<export>
<lib name="1"/>
</export>
1 change: 1 addition & 0 deletions DataFormats/FTLRecHit/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/ForwardDetId"/>
<use name="DataFormats/TrackingRecHit"/>
<use name="DataFormats/DetId"/>
<export>
<lib name="1"/>
</export>
36 changes: 36 additions & 0 deletions RecoTracker/TkSeedGenerator/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,42 @@
<use name="RecoPixelVertexing/PixelTriplets"/>
<use name="RecoPixelVertexing/PixelTrackFitting"/>
<use name="RecoPixelVertexing/PixelLowPtUtilities"/>
<use name="CommonTools/Utils"/>
<use name="DataFormats/BeamSpot"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/Math"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/SiStripDetId"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/TrackerCommon"/>
Copy link
Contributor

@slava77 slava77 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<use name="DataFormats/TrackerCommon"/>

not used

Copy link
Contributor Author

@davidlange6 davidlange6 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in SeedingOTEDProducer.cc

<use name="DataFormats/TrackingRecHit"/>
<use name="DataFormats/TrajectorySeed"/>
<use name="DataFormats/TrajectoryState"/>
<use name="DataFormats/VertexReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/Utilities"/>
<use name="Geometry/CommonDetUnit"/>
<use name="Geometry/Records"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="MagneticField/Engine"/>
<use name="MagneticField/Records"/>
<use name="MagneticField/UniformEngine"/>
<use name="RecoTracker/MeasurementDet"/>
<use name="RecoTracker/Record"/>
<use name="RecoTracker/SpecialSeedGenerators"/>
<use name="RecoTracker/TkHitPairs"/>
<use name="RecoTracker/TkSeedingLayers"/>
<use name="RecoTracker/TransientTrackingRecHit"/>
<use name="TrackingTools/GeomPropagators"/>
<use name="TrackingTools/KalmanUpdators"/>
<use name="TrackingTools/MeasurementDet"/>
<use name="TrackingTools/PatternTools"/>
Comment on lines +39 to +40
Copy link
Contributor

@slava77 slava77 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<use name="TrackingTools/MeasurementDet"/>
<use name="TrackingTools/PatternTools"/>

apparently not used in CMSSW_11_1_X_2020-10-27-1100

Copy link
Contributor Author

@davidlange6 davidlange6 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used an IB of ~5 days ago. I'll look at what went right or wrong...

Copy link
Contributor Author

@davidlange6 davidlange6 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in SeedingOTEDProducer.cc (and PatternTools is also used in SeedCombiner)

Copy link
Contributor

@slava77 slava77 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently not used in CMSSW_11_1_X_2020-10-27-1100

ehm, why was I looking at an old release cycle

<use name="TrackingTools/Records"/>
<use name="TrackingTools/TrajectoryState"/>
<use name="TrackingTools/TransientTrackingRecHit"/>
Copy link
Contributor

@slava77 slava77 Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many of these dependencies are declared in RecoTracker/TkSeedGenerator.
Is it time to cleanup that package dependencies?

Copy link
Contributor Author

@davidlange6 davidlange6 Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its correct to have dependencies in both src and plugins BuildFiles assuming both src and plugins use them directly (at least that is my understanding of the correct way to manage BuildFiles).

<library file="*.cc" name="RecoTrackerTkSeedGeneratorPlugins">
<flags EDM_PLUGIN="1"/>
<use name="DataFormats/TrackerRecHit2D"/>
Expand Down