add missing includes #31932

davidlange6 · 2020-10-24T12:39:15Z

The modules IB started having compilation errors after #31704 was merged. I believe (now confirmed) this is due to a missing Eigen dependency in the buildfile of DataFormats/CaloRecoHit. I'm adding other buildfile fixes that I found along the way..

cmsbuild · 2020-10-24T12:39:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-24T12:46:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31932/19373

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/TkSeedGenerator/plugins/BuildFile.xml modified in PR(s): Patatrack integration - Pixel track reconstruction (10/N) #31722, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-10-24T12:46:49Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/CaloRecHit
DataFormats/FTLRecHit
RecoTracker/TkSeedGenerator

@perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2020-10-24T13:38:50Z

cmsbuild · 2020-10-24T13:39:13Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10270/console Started: 2020/10/24 15:39

slava77 · 2020-10-24T15:01:19Z

RecoTracker/TkSeedGenerator/plugins/BuildFile.xml

+<use name="TrackingTools/PatternTools"/>
+<use name="TrackingTools/Records"/>
+<use name="TrackingTools/TrajectoryState"/>
+<use name="TrackingTools/TransientTrackingRecHit"/>


many of these dependencies are declared in RecoTracker/TkSeedGenerator.
Is it time to cleanup that package dependencies?

its correct to have dependencies in both src and plugins BuildFiles assuming both src and plugins use them directly (at least that is my understanding of the correct way to manage BuildFiles).

cmsbuild · 2020-10-24T16:14:54Z

+1
Tested at: c1f32cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc7a/10270/summary.html
CMSSW: CMSSW_11_2_X_2020-10-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-24T16:14:56Z

Comparison job queued.

cmsbuild · 2020-10-24T17:27:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc7a/10270/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544110
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544087
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

kpedro88 · 2020-10-26T22:37:05Z

+upgrade

slava77

it looks like several dependencies in RecoTracker/TkSeedGenerator/plugins/BuildFile.xml are not used/included.

was the list derived in some older release where these packages were still used or is there some longer-range dependency addition?

slava77 · 2020-10-27T14:36:04Z

RecoTracker/TkSeedGenerator/plugins/BuildFile.xml

+<use name="TrackingTools/MeasurementDet"/>
+<use name="TrackingTools/PatternTools"/>


Suggested change

<use name="TrackingTools/MeasurementDet"/>

<use name="TrackingTools/PatternTools"/>

apparently not used in CMSSW_11_1_X_2020-10-27-1100

I used an IB of ~5 days ago. I'll look at what went right or wrong...

used in SeedingOTEDProducer.cc (and PatternTools is also used in SeedCombiner)

apparently not used in CMSSW_11_1_X_2020-10-27-1100

ehm, why was I looking at an old release cycle

slava77 · 2020-10-27T14:42:08Z

RecoTracker/TkSeedGenerator/plugins/BuildFile.xml

+<use name="DataFormats/SiPixelDetId"/>
+<use name="DataFormats/SiStripDetId"/>
+<use name="DataFormats/TrackReco"/>
+<use name="DataFormats/TrackerCommon"/>


Suggested change

<use name="DataFormats/TrackerCommon"/>

not used

in SeedingOTEDProducer.cc

slava77 · 2020-10-27T16:19:29Z

+1

for #31932 c1f32cc

technical;

the updates are apparently all used, sorry for the noise earlier, it came from using an older release cycle for a check

cmsbuild · 2020-10-27T16:19:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-28T07:19:31Z

+1

davidlange6 added 2 commits October 24, 2020 14:31

add missing includes

9c3a719

improve buildfile layout

c1f32cc

cmsbuild added this to the CMSSW_11_2_X milestone Oct 24, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Oct 24, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 24, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2020

slava77 reviewed Oct 24, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Oct 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 24, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 26, 2020

slava77 reviewed Oct 27, 2020

View reviewed changes

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 27, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 28, 2020

cmsbuild merged commit 42070df into cms-sw:master Oct 28, 2020

		<use name="TrackingTools/MeasurementDet"/>
		<use name="TrackingTools/PatternTools"/>

add missing includes #31932

add missing includes #31932

Uh oh!

Conversation

davidlange6 commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

davidlange6 commented Oct 24, 2020 via email

Uh oh!

cmsbuild commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

cmsbuild commented Oct 24, 2020

Uh oh!

kpedro88 commented Oct 26, 2020

Uh oh!

slava77 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slava77 commented Oct 27, 2020

Uh oh!

cmsbuild commented Oct 27, 2020

Uh oh!

qliphy commented Oct 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidlange6 commented Oct 24, 2020 •

edited

Loading

cmsbuild commented Oct 24, 2020 •

edited

Loading