MTD geometry: DD4hep specPar update, additional fix

[fabiocos]

PR description:

This PR follows #31879 fixing one instance of the old syntax for SpecParRegistry not migrated because hidden by a commented EDM_ML_DEBUG statement. At the same time clean a bit the categories used by MessageLogger in the same class.

PR validation:

Code compiles, unit tests are ok without geometry changes, if the debugging statement is activated it properly compiles and run.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31921/19347

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31921/19347/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31921/19347/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31921/19354

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10244/console Started: 2020/10/23 15:17

[cmsbuild]

+1
Tested at: 9f2776c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a4319/10244/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a4319/10244/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544110
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544087
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[kpedro88]

+upgrade

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[fabiocos]

@silviodonato @qliphy @smuzaffar this PR has broken the IB (unit tests), I do not understand anyway why this hasn't been seen in the PR test itself

[fabiocos]

@silviodonato @qliphy @smuzaffar I was wrong, in fact there is nothing in the PR that should affect the unit tests. A quick standalone test shows that the problem comes from #31886 by @ianna , I'll try to see what is causing it (anyway a proof that these unit tests are useful...)

[ianna]

@silviodonato @qliphy @smuzaffar I was wrong, in fact there is nothing in the PR that should affect the unit tests. A quick standalone test shows that the problem comes from #31886 by @ianna , I'll try to see what is causing it (anyway a proof that these unit tests are useful...)

@fabiocos - thanks for pointing this out. The PR #31934 fixes the DT geometry unit test. A namespace needed to be stripped off for a name comparison. Are you looking into the MTD code or shall I do it? Please, let me know. Thanks!

[ianna]

@silviodonato @qliphy @smuzaffar I was wrong, in fact there is nothing in the PR that should affect the unit tests. A quick standalone test shows that the problem comes from #31886 by @ianna , I'll try to see what is causing it (anyway a proof that these unit tests are useful...)

@fabiocos - thanks for pointing this out. The PR #31934 fixes the DT geometry unit test. A namespace needed to be stripped off for a name comparison. Are you looking into the MTD code or shall I do it? Please, let me know. Thanks!

ok, the PR #31934 should fix all the tests.