[DD4hep] Update to DD4hep master of 16.10.2020 #31821

ianna · 2020-10-16T08:48:04Z

PR description:

@mrodozov - FYI. This should fix compilation errors in Update DD4Hep to latest commit on master cmsdist#6315

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-10-16T08:48:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-16T08:52:33Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315

CMSSW_11_2_X_2020-10-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10010/console Started: 2020/10/16 10:55

cmsbuild · 2020-10-16T08:55:00Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:43: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                          ^
                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:44: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:59: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                          ^
                                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:60: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                          ^
                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:180:26: error: no member named 'isRegex' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->isRegex.emplace_back(isRegex);
                         ^
Suppressed 2058 warnings (2057 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02650/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:110: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                             ^
                                                                                                             ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:111: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                              ^
Suppressed 2263 warnings (2262 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1157 warnings (1156 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::realTopName(pit), dd4hep::dd::noNamespace(it.first.name()))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:52: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                   ^
                                                   ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:53: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                    ^
Suppressed 2251 warnings (2250 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                           ^
Suppressed 2892 warnings (2891 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:19: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                  ^
                  ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:20: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                   ^
Suppressed 2631 warnings (2630 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:29: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                            ^
                            ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:30: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                             ^
Suppressed 3481 warnings (3480 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
Suppressed 3734 warnings (3732 in non-user code, 2 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-16T09:21:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-16T09:32:48Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:43: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                          ^
                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:44: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:59: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                          ^
                                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:60: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                          ^
                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:180:26: error: no member named 'isRegex' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->isRegex.emplace_back(isRegex);
                         ^
Suppressed 2058 warnings (2057 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02650/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:110: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                             ^
                                                                                                             ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:111: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                              ^
Suppressed 2263 warnings (2262 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::realTopName(pit), dd4hep::dd::noNamespace(it.first.name()))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:52: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                   ^
                                                   ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:53: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                    ^
Suppressed 2251 warnings (2250 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1157 warnings (1156 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:19: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                  ^
                  ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:20: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                   ^
Suppressed 2631 warnings (2630 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                           ^
Suppressed 2892 warnings (2891 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:29: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                            ^
                            ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:30: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                             ^
Suppressed 3481 warnings (3480 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
Suppressed 3734 warnings (3732 in non-user code, 2 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-16T11:26:50Z

-1

Tested at: f759085

CMSSW: CMSSW_11_2_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3877c/10010/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

Copying tmp/slc7_amd64_gcc820/src/SimG4Core/DD4hepGeometry/test/DD4hepGeometryTestDriver/DD4hepGeometryTestDriver to productstore area:
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc: In lambda function:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& sit : fit->spars) {
                                   ^~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:112:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& pit : fit->paths) {
                                   ^~

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/dummyMain.cpp
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: member reference type 'const std::pair, std::allocator >, const dd4hep::SpecPar *>' is not a pointer; did you mean to use '.'?
        for (auto const& sit : fit->spars) {
                               ~~~^~
                                  .
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:37: error: no member named 'spars' in 'std::pair, std::allocator >, const dd4hep::SpecPar *>'
        for (auto const& sit : fit->spars) {

cmsbuild · 2020-10-16T11:26:53Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-10-21T06:21:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-21T06:22:10Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31770,#31810

CMSSW_11_2_X_2020-10-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10162/console Started: 2020/10/21 08:24

cmsbuild · 2020-10-21T06:28:46Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:43: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                          ^
                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:44: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:59: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                          ^
                                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:60: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:168:44: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& partSelector : section.second->paths) {
                                           ^
                                           ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:168:45: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& partSelector : section.second->paths) {
                                            ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:26: error: no member named 'hasNamespace' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->hasNamespace.emplace_back(dd4hep::dd::hasNamespace(firstPartName));
                         ^
Suppressed 2057 warnings (2056 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02651/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:110: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                             ^
                                                                                                             ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:111: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                              ^
Suppressed 2262 warnings (2261 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::realTopName(pit), dd4hep::dd::noNamespace(it.first.name()))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:52: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                   ^
                                                   ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:53: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                    ^
Suppressed 2250 warnings (2249 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1156 warnings (1155 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_MaterialAccountingGroup.cc:38:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& k : j.second->paths) {
                           ^
Suppressed 2891 warnings (2890 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:19: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                  ^
                  ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListIds.cc:54:20: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    tkdss.insert(t.second->strValue(attribute));
                   ^
Suppressed 2630 warnings (2629 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                          ^
                          ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:370:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    m_group_names.insert(t.second->strValue("TrackingMaterialGroup"));
                           ^
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:29: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                            ^
                            ->
SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc:379:30: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto &k : j.second->paths) {
                             ^
Suppressed 3480 warnings (3479 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDCompactView.h:61:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDCompactView.h:61:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      if (mySpecParSection.second->hasPath(nodePath)) {
                           ^
DetectorDescription/DDCMS/interface/DDCompactView.h:62:32: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                               ^
                               ->
DetectorDescription/DDCMS/interface/DDCompactView.h:62:33: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        return mySpecParSection.second->value<std::vector<T>>(parameterName);
                                ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
Suppressed 3733 warnings (3731 in non-user code, 2 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-21T06:49:03Z

-1
@ianna This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31821/10162/git-merge-result

ianna · 2020-10-21T22:06:47Z

merged in #31879

cmsbuild added this to the CMSSW_11_2_X milestone Oct 16, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Oct 16, 2020

ianna mentioned this pull request Oct 16, 2020

Update DD4Hep to latest commit on master cms-sw/cmsdist#6315

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Oct 16, 2020

cmsbuild added code-checks-rejected code-checks-pending tests-pending and removed code-checks-pending code-checks-rejected requires-external tests-started labels Oct 16, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 16, 2020

ianna and others added 10 commits October 21, 2020 08:19

use regex comparison if selection is a regex

51e0872

remove unused variable

d2bd23f

update to new vesrion of dd4hep

f378701

reverse comparison

91c03b5

replace tbb containers with std ones

57d5c21

no need for atomic

0e150aa

final changes and cleanup

cc4a2bb

clang tidy

df10acf

one more fix and code format

69d5103

clean up filter test and merge specifics

97744b8

ianna force-pushed the dd4hep-update-16.10.2020 branch from 0573325 to 97744b8 Compare October 21, 2020 06:20

cmsbuild added code-checks-pending tests-pending and removed code-checks-rejected requires-external tests-started labels Oct 21, 2020

cmsbuild added requires-external tests-started and removed tests-pending labels Oct 21, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 21, 2020

ianna mentioned this pull request Oct 21, 2020

[DD4hep] Update to master 21 10 2020 #31879

Merged

cmsbuild mentioned this pull request Oct 21, 2020

[DD4hep] Reintroduce Namespace #31886

Merged

ianna closed this Oct 21, 2020

ianna deleted the dd4hep-update-16.10.2020 branch June 25, 2025 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] Update to DD4hep master of 16.10.2020 #31821

[DD4hep] Update to DD4hep master of 16.10.2020 #31821

Uh oh!

ianna commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020 •

edited

Loading

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

cmsbuild commented Oct 21, 2020 •

edited

Loading

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

ianna commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[DD4hep] Update to DD4hep master of 16.10.2020 #31821

[DD4hep] Update to DD4hep master of 16.10.2020 #31821

Uh oh!

Conversation

ianna commented Oct 16, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

cmsbuild commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

ianna commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cmsbuild commented Oct 16, 2020 •

edited

Loading

cmsbuild commented Oct 21, 2020 •

edited

Loading