[DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770

ianna · 2020-10-13T14:08:14Z

PR description:

Final changes that replace tbb with std

Note: requires AIDASoft/DD4hep#723 to be merged in DD4hep master.

TimeModule> 1 1 test DDCMSDetector 1.77687
TimeModule> 1 1 testVectors DDTestVectors 0.000743151
TimeModule> 1 1 testDump DDTestDumpFile 0.47807
TimeModule> 1 1 testGeoIter DDTestDumpGeometry 6.12371
TimeModule> 1 1 p PathStatusInserter 5.60284e-05
TimeModule> 1 1 TriggerResults TriggerResultInserter 2.81334e-05
TimeEvent> 1 1 8.38048
MemoryReport> Peak virtual size 812.355 Mbytes
rss = 247.629

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-10-13T14:08:40Z

The code-checks are being triggered in jenkins.

ianna · 2020-10-13T14:13:53Z

hold

cmsbuild · 2020-10-13T14:14:58Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1222 warnings (1221 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << t.first << "\nRegExps { ";
                              ^
                              ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:32: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << t.first << "\nRegExps { ";
                               ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:168:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                          ^
                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:168:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:26: error: no member named 'isRegex' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->isRegex.emplace_back(isRegex);
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:182:26: error: no member named 'hasNamaspace' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->hasNamaspace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:182:64: error: no member named 'hasNamespace' in namespace 'dd4hep::dd'; did you mean 'noNamespace'? [clang-diagnostic-error]
        filters_.back()->hasNamaspace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                                                               ^~~~~~~~~~~~
                                                               noNamespace
--
DetectorDescription/DDCMS/src/DDFilteredView.cc:184:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->keys.size());
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:187:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->skeys.size());
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:191:34: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        filters_.back()->spec = i.second;
                                 ^
                                 ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:191:35: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        filters_.back()->spec = i.second;
                                  ^
Suppressed 2080 warnings (2079 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02650/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

ianna · 2020-10-13T14:23:20Z

code check failures are expected - this requires an external update

cmsbuild · 2020-10-13T15:14:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-13T15:19:55Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:31: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << t.first << "\nRegExps { ";
                              ^
                              ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:32: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << t.first << "\nRegExps { ";
                               ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                          ^
                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:180:26: error: no member named 'isRegex' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->isRegex.emplace_back(isRegex);
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:26: error: no member named 'hasNamaspace' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->hasNamaspace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:64: error: no member named 'hasNamespace' in namespace 'dd4hep::dd'; did you mean 'noNamespace'? [clang-diagnostic-error]
        filters_.back()->hasNamaspace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                                                               ^~~~~~~~~~~~
                                                               noNamespace
--
DetectorDescription/DDCMS/src/DDFilteredView.cc:183:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->keys.size());
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:186:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->skeys.size());
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:190:34: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        filters_.back()->spec = i.second;
                                 ^
                                 ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:190:35: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        filters_.back()->spec = i.second;
                                  ^
Suppressed 2080 warnings (2079 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02650/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1222 warnings (1221 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-14T17:20:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-14T17:24:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-14T17:28:59Z

-code-checks

ERROR: Build errors found during clang-tidy run.

DetectorDescription/DDCMS/interface/DDFilteredView.h:175:40: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                       ^
                                       ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:175:41: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
        for (const auto& part : specPar.second->paths) {
                                        ^
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                          ^
                          ->
DetectorDescription/DDCMS/interface/DDFilteredView.h:188:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
            return specPar.second->value<std::vector<T>>(key);
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:43: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                          ^
                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:44: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:59: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                          ^
                                                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:53:60: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      log << "\nSpecPar " << std::string(t.first.data(), t.first.size()) << "\nRegExps { ";
                                                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:54:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:57:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:27: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                          ^
                          ->
DetectorDescription/DDCMS/src/DDFilteredView.cc:167:28: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    for (const auto& j : i.second->paths) {
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:180:26: error: no member named 'isRegex' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->isRegex.emplace_back(isRegex);
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:26: error: no member named 'hasNamespace' in 'dd4hep::Filter' [clang-diagnostic-error]
        filters_.back()->hasNamespace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                         ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:181:64: error: no member named 'hasNamespace' in namespace 'dd4hep::dd'; did you mean 'noNamespace'? [clang-diagnostic-error]
        filters_.back()->hasNamespace.emplace_back(dd4hep::dd::hasNamespace(firstTok));
                                                               ^~~~~~~~~~~~
                                                               noNamespace
--
DetectorDescription/DDCMS/src/DDFilteredView.cc:183:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->keys.size());
                           ^
DetectorDescription/DDCMS/src/DDFilteredView.cc:186:28: error: no member named 'index' in 'dd4hep::Filter' [clang-diagnostic-error]
          filters_.back()->index.emplace_back(filters_.back()->skeys.size());
                           ^
Suppressed 2080 warnings (2079 in non-user code, 1 with check filters).
--
DetectorDescription/DDCMS/src/DDCompactView.cc:51:14: error: no viable conversion from returned value of type 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to function return type 'const std::vector<double>' [clang-diagnostic-error]
      return nitem->second;
             ^
/cvmfs/cms-ib.cern.ch/nweek-02650/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:458:7: note: candidate constructor not viable: no known conversion from 'tbb::concurrent_vector<double, tbb::cache_aligned_allocator<double> >' to 'const std::vector<double, std::allocator<double> > &' for 1st argument
--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:55:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& ki : t.second->paths)
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:30: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                             ^
                             ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:58:31: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (const auto& kl : t.second->spars) {
                              ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:11: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
          ^
          ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:69:12: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
    if (it.second->hasPath("//ME11AlumFrame")) {
           ^
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:22: error: member reference type 'const dd4hep::SpecPar *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      std::cout << it.first << "\n";
                     ^
                     ->
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:70:23: error: no member named 'first' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      std::cout << it.first << "\n";
                      ^
Suppressed 1222 warnings (1221 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-19T13:01:01Z

-1

Tested at: c09ccdb

CMSSW: CMSSW_11_2_X_2020-10-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10073/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

Copying tmp/slc7_amd64_gcc820/src/SimG4Core/DD4hepGeometry/test/DD4hepGeometryTestDriver/DD4hepGeometryTestDriver to productstore area:
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc: In lambda function:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& sit : fit->spars) {
                                   ^~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:112:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& pit : fit->paths) {
                                   ^~

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/dummyMain.cpp
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: member reference type 'const std::pair, std::allocator >, const dd4hep::SpecPar *>' is not a pointer; did you mean to use '.'?
        for (auto const& sit : fit->spars) {
                               ~~~^~
                                  .
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:37: error: no member named 'spars' in 'std::pair, std::allocator >, const dd4hep::SpecPar *>'
        for (auto const& sit : fit->spars) {

cmsbuild · 2020-10-19T13:01:10Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-10-19T13:59:59Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31810,#31821

CMSSW_11_2_X_2020-10-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10079/console Started: 2020/10/19 16:01

cmsbuild · 2020-10-19T19:10:28Z

-1

Tested at: c09ccdb

CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10079/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test GeometryDTGeometryBuilderTestDriver had ERRORS
---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

cmsbuild · 2020-10-19T19:10:37Z

Comparison job queued.

cmsbuild · 2020-10-19T20:26:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10079/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543752
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543723
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-10-20T20:55:42Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31810,#31821

CMSSW_11_2_X_2020-10-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10156/console Started: 2020/10/20 22:57

cmsbuild · 2020-10-20T21:35:36Z

-1
@ianna This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31770/10156/git-merge-result

cmsbuild · 2020-10-21T06:22:08Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31810,#31821

CMSSW_11_2_X_2020-10-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10162/console Started: 2020/10/21 08:24

cmsbuild · 2020-10-21T06:48:58Z

-1
@ianna This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31770/10162/git-merge-result

ianna · 2020-10-21T22:05:55Z

merged in #31879

cmsbuild added this to the CMSSW_11_2_X milestone Oct 13, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Oct 13, 2020

cmsbuild added the hold label Oct 13, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 13, 2020

ianna mentioned this pull request Oct 13, 2020

DD4hep update cms-sw/cmsdist#6308

Closed

cmsbuild added code-checks-pending upgrade-pending and removed code-checks-rejected labels Oct 13, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 13, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 14, 2020

cmsbuild mentioned this pull request Oct 14, 2020

Fix to allow concurrent processing of lumisections with ECAL DQM #31689

Merged

cmsbuild added the tests-started label Oct 19, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 19, 2020

cmsbuild added tests-started and removed tests-rejected labels Oct 19, 2020

cmsbuild added comparison-pending tests-rejected and removed comparison-notrun tests-started labels Oct 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 19, 2020

cmsbuild added tests-started and removed tests-rejected labels Oct 20, 2020

ianna mentioned this pull request Oct 21, 2020

[DD4hep] Update to master 21 10 2020 #31879

Merged

cmsbuild mentioned this pull request Oct 21, 2020

[DD4hep] Reintroduce Namespace #31886

Merged

ianna closed this Oct 21, 2020

ianna deleted the dd4hep-replace-tbb-with-std-v3 branch June 25, 2025 18:51

[DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770

[DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770

Uh oh!

Conversation

ianna commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Oct 13, 2020

Uh oh!

ianna commented Oct 13, 2020

Uh oh!

cmsbuild commented Oct 13, 2020

Uh oh!

ianna commented Oct 13, 2020

Uh oh!

cmsbuild commented Oct 13, 2020

Uh oh!

cmsbuild commented Oct 13, 2020

Uh oh!

cmsbuild commented Oct 14, 2020

Uh oh!

cmsbuild commented Oct 14, 2020

Uh oh!

cmsbuild commented Oct 14, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

ianna commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ianna commented Oct 13, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 21, 2020 •

edited

Loading