-
Notifications
You must be signed in to change notification settings - Fork 207
Pythia 8.315 #9943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythia 8.315 #9943
Conversation
|
A new Pull Request was created by @mseidel42 for branch IB/CMSSW_15_1_X/master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Needs cms-sw/cmssw#48422 |
|
test parameters:
|
|
please test |
|
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: RelVals |
|
GEN-SIM step ran fine as far as I can see |
|
please test |
|
-1 Failed Tests: RelVals RelVals |
|
Hi, could you ping someone from TICL to have a look at this? |
|
@cmsbuild, please test Let's refresh the tests |
It's possible, but is the plan really to validate with a central production campaign? Because if we end up just doing private production anyway, then this would be wasted effort. |
It's an idea that we are considering for this kind of validations. |
|
The key point is that it’s much easier to find people willing to perform validation if there’s a “central” but purpose-specific CMS release that can be used with McM for producing validation samples. Expecting individuals to handle both MC generation and the subsequent validation studies on their own—and trusting that this will be completed in time before January—is unrealistic. At the moment, no one is actually committed to carrying out validation work for the Pythia upgrade. So, what’s the benefit of including it in the pre-release now, if we’ll just need to remove it again before January 2026? |
|
The benefit is that you have a pre-release to validate. Which is the point of pre-releases! In principle any feature included in a prerelease may have to be rolled back, if the validation is not successful in time. We can of course treat generators separately, if it's warranted. It creates more work, but if there's a strong reason why you can't simply benefit from pre-releases, we can discuss it |
|
The problem is that pre-releases have a short lifetime as far as I know, so it's tricky to use them in a central production campaign in McM. Also we should bear in mind that, if there's any issue with the new version of pythia (or any other generator in CMSSW) all the relvals that are run to validate the pre-releases could potentially fail because of this. |
|
I do not see a clear advantage of a pre-release compared to a dedicated pythia8315 release for validation. In both cases, private samples would still need to be produced by individuals, which slows down the process and makes validation less appealing for volunteers. A pre-release also carries the risk of prematurely entering the main release cycle, which could result in large-scale production before validation is complete and effectively leave CMS analyzers acting as a posteriori validators. A more robust approach would be to provide a dedicated release (e.g. release-X) that can be used directly with McM for producing validation samples. This release would remain outside the main release pipeline until validation is finalized, thereby avoiding premature large-scale MC production. |
|
hold |
|
Pull request has been put on hold by @mandrenguyen |
|
I would really encourage @cms-sw/generators-l2 to make use 16_0_0_pre1 for pythia 8.315 in this instance AND have a discussion about dedicated gen releases going forward at the next ORP. I don't think we should hold up pythia 8.315 until we have settled on a broader strategy. But this is your call. |
|
Fwiw, we have a student coming to CERN this month who was supposed to do Vincia validation. |
No, pre-releases are kept "forever".
Pre-release approach follows the standard procedure everyone else follows, whereas special releases create extra work for those who prepare that release. Special releases can be done, and the amount of work is not that much, but they do need to be well motivated. |
|
My hesitation is that generator version changes can be frequent, and this creates extra work for the core and ORP teams, which can delay generator integration (although at the current pace perhaps the extra delay is negligible). It's possible, but there is a cost. Following the release schedule imposes deadlines (a good thing) and helps makes sure that generator developments stay in sync with other developments. |
Ok, thanks for the info. Sorry, I was not aware of this. I guess we could try using a pre-release, but I would like to clarify that the validation of a new generator is totally different from all the other release validations that we usually do. I can imagine that if we extend this kind of validation to multiple new generators (Herwig, Sherpa, ...), the current approach will most likely fail. |
|
"Taking long time" could be a good-enough reason to motivate special (pre-)releases. That's not too different with what we do for GCC and ROOT, although for them the primary motivation of a special validation is the huge amount of numerical changes either update usually creates, and the long validation time is more of a matter of reality. I'll let @smuzaffar to comment on the feasibility on practical level. |
|
Hello, after discussing with @mseidel42 and @theofil, we decided to include this in a pre-release this time. We will check how the validation will go and in case consider a stable release for the next time. |
|
+generators |
|
+externals |
|
unhold
We are happy to have that discussion. Probably folks from PPD/PdMV should be in the loop. |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will be automatically merged. |
Hi, sorry I missed this discussion. Ideally, the special pre-release method (as Matti was suggesting, and as we do for ROOT) is the preferred solution since any change would most probably be hidden below all the other changes occurring in the standard pre-release cycle, unless they are very catastrophic, which I hope is never the case. If we can stick to ~1 change of version per year (as it seems to be the case, looking at the PRs history), this would be bearable. |
Same updates as for Pythia 8.313 (#9612), specifically
Full changelog here: https://pythia.org/latest-manual/UpdateHistory.html#section0