ROCM: do not set --gcc-toolchain/--target via toolfile #9895

smuzaffar · 2025-05-28T09:04:44Z

--gcc-toolchain and --target are now set via rocm/llvm/bin/clang++.cfg (see #9893 ), so no need to set these via scram rocm.xml toolfile

cmsbuild · 2025-05-28T09:05:03Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-05-28T09:05:04Z

cms-bot internal usage

smuzaffar · 2025-05-28T09:05:12Z

test parameters:

addpkg = HeterogeneousCore, HeterogeneousTest, DataFormats

smuzaffar · 2025-05-28T09:05:17Z

please test

smuzaffar · 2025-05-28T09:05:37Z

please test for el8_aarch64_gcc12

smuzaffar · 2025-05-28T09:06:15Z

please test for el9_amd64_gcc14

smuzaffar · 2025-05-28T09:32:03Z

please test for CMSSW_15_1_CLANG_X

smuzaffar · 2025-05-28T09:34:43Z

test comment

cmsbuild · 2025-05-28T10:54:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46398/summary.html
COMMIT: f67dc98
CMSSW: CMSSW_15_1_X_2025-05-27-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9895/46398/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46398/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46398/git-merge-result

smuzaffar · 2025-05-28T11:06:38Z

please test

smuzaffar · 2025-05-28T11:06:59Z

please test for CMSSW_15_1_CLANG_X

smuzaffar · 2025-05-28T11:10:28Z

please test for CMSSW_15_1_CLANG_X

smuzaffar · 2025-05-28T11:10:40Z

please test

cmsbuild · 2025-05-28T15:13:44Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46405/summary.html
COMMIT: f67dc98
CMSSW: CMSSW_15_1_X_2025-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9895/46405/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46405/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46405/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test SagittaBiasNtuplizer had ERRORS

Comparison Summary

Summary:

You potentially added 43 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 90
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4038083
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3026.7509999999997 KiB( 49 files compared)
DQMHistoSizes: changed ( 24834.911,... ): 432.393 KiB HLT/HGCAL
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-05-28T15:18:57Z

+externals

cmsbuild · 2025-05-28T15:19:17Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2025-05-28T21:25:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46406/summary.html
COMMIT: f67dc98
CMSSW: CMSSW_15_1_CLANG_X_2025-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9895/46406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 604 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 101606 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 571859
DQMHistoTests: Total nulls: 434
DQMHistoTests: Total successes: 3465880
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3029.0699999999997 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -2.183 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 141.042 ): -0.023 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.014 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.104 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.202 ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.301,... ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.5 ): 0.027 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.604 ): 0.055 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.713 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 17034.0 ): ...
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: found differences in 20 / 48 workflows

cmsbuild · 2025-05-29T04:17:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46407/summary.html
COMMIT: f67dc98
CMSSW: CMSSW_15_1_X_2025-05-27-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9895/46407/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46407/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf80b/46407/git-merge-result

Comparison Summary

Summary:

You potentially added 412 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 100281 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 541221
DQMHistoTests: Total nulls: 463
DQMHistoTests: Total successes: 3496489
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3037.096 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.010 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 4.737 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 140.045,... ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.042 ): 0.035 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.408 ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.5 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.604 ): 0.152 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.713 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 17034.0 ): 1.816 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 24834.911,... ): 432.393 KiB HLT/HGCAL
DQMHistoSizes: changed ( 250202.181 ): ...
Checked 215 log files, 184 edm output root files, 50 DQM output files

ROCM: do not set --gcc-toolchain/--target via toolfile

f67dc98

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels May 28, 2025

cmsbuild added tests-started and removed tests-pending labels May 28, 2025

cmsbuild added tests-rejected and removed tests-started labels May 28, 2025

smuzaffar merged commit 8afae37 into IB/CMSSW_15_1_X/master May 28, 2025
21 of 24 checks passed

smuzaffar deleted the rocm-toolfile-cleanup branch May 28, 2025 15:19

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels May 28, 2025

This was referenced May 28, 2025

Bump conifer to 1.7 #9898

Merged

created clang++.cfg and clang.cfg files and dropped --gcc-toolchain from toolfile #9896

Merged

ROCM: do not set --gcc-toolchain/--target via toolfile #9895

ROCM: do not set --gcc-toolchain/--target via toolfile #9895

Uh oh!

Conversation

smuzaffar commented May 28, 2025

Uh oh!

cmsbuild commented May 28, 2025

Uh oh!

cmsbuild commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

cmsbuild commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

cmsbuild commented May 28, 2025

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

Uh oh!

cmsbuild commented May 28, 2025

Uh oh!

cmsbuild commented May 28, 2025

Comparison Summary

Uh oh!

cmsbuild commented May 29, 2025

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented May 28, 2025 •

edited

Loading

smuzaffar commented May 28, 2025 •

edited

Loading