Skip to content

created clang++.cfg and clang.cfg files and dropped --gcc-toolchain from toolfile #9896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smuzaffar merged 3 commits into from
May 29, 2025
Merged

created clang++.cfg and clang.cfg files and dropped --gcc-toolchain from toolfile #9896

smuzaffar merged 3 commits into from
May 29, 2025

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented May 28, 2025

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 28, 2025

please test for CMSSW_15_1_CLANG_X using full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46408/summary.html
COMMIT: 6cc1112
CMSSW: CMSSW_15_1_CLANG_X_2025-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9896/46408/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

install: omitting directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/llvm-19.1.6-8b7cd04d9c367791750225cd6083b1bb02a1a944/clang/tools/scan-build/share/scan-build'
+ find /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/llvm-19.1.6-8b7cd04d9c367791750225cd6083b1bb02a1a944/clang/tools/scan-view -type f -exec install '{}' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/1dcf745df23bc3230e5a7a474aa87a97/opt/cmssw/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/bin ';'
+ rm -f /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/1dcf745df23bc3230e5a7a474aa87a97/opt/cmssw/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/bin/FileRadar.scpt /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/1dcf745df23bc3230e5a7a474aa87a97/opt/cmssw/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/bin/GetRadarVersion.scpt
+ rm -f /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/1dcf745df23bc3230e5a7a474aa87a97/opt/cmssw/el8_amd64_gcc12/external/llvm/19.1.6-1dcf745df23bc3230e5a7a474aa87a97/bin/set-xcode-analyzer
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DymFQ4: line 60: syntax error near unexpected token `<<<'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DymFQ4 (%install)


RPM build errors:
Macro expanded in comment on line 404: %{pkginstroot}/lib64

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 28, 2025

please test using full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46420/summary.html
COMMIT: 6cc1112
CMSSW: CMSSW_15_1_X_2025-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9896/46420/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
* The action "build-external+mozsearch+20240514-b0933ef23d105b9ae07da239cd6de768" was not completed successfully because Failed to build mozsearch. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/mozsearch/20240514-b0933ef23d105b9ae07da239cd6de768/log. Final lines of the log file:
clang++: clang++warning: clang++: : argument unused during compilation: '--gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28' [-Wunused-command-line-argument]warning: warning: 
argument unused during compilation: '--gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28' [-Wunused-command-line-argument]argument unused during compilation: '--gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28' [-Wunused-command-line-argument]

error: unknown target triple 'unknown'
clang++: warning: argument unused during compilation: '--gcc-toolchain=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28' [-Wunused-command-line-argument]
error: unknown target triple 'unknown'
error: unknown target triple 'unknown'
error: unknown target triple 'unknown'
error: unknown target triple 'unknown'

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 28, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

Pull request #9896 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46424/summary.html
COMMIT: 7edc998
CMSSW: CMSSW_15_1_X_2025-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9896/46424/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

-- Installing: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/c65ce4e79282e336583e28282aba3baa/opt/cmssw/el8_amd64_gcc12/external/llvm/18.1.6-c65ce4e79282e336583e28282aba3baa/lib64/cmake/llvm/LLVMConfigExtensions.cmake
++ gcc -dumpmachine
+ host_triple=x86_64-redhat-linux-gnu
+ ln -s x86_64-redhat-linux-gnu/libomp.so /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/c65ce4e79282e336583e28282aba3baa/opt/cmssw/el8_amd64_gcc12/external/llvm/18.1.6-c65ce4e79282e336583e28282aba3baa/lib64/libomp.so
ln: failed to create symbolic link '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/c65ce4e79282e336583e28282aba3baa/opt/cmssw/el8_amd64_gcc12/external/llvm/18.1.6-c65ce4e79282e336583e28282aba3baa/lib64/libomp.so': File exists
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.baKwuY (%install)


RPM build errors:
Macro expanded in comment on line 404: %{pkginstroot}/lib64

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 28, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

Pull request #9896 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46432/summary.html
COMMIT: 84e512f
CMSSW: CMSSW_15_1_X_2025-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9896/46432/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46432/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6847b5/46432/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4041063
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4041043
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 29, 2025

+externals

@smuzaffar smuzaffar merged commit fb97e02 into IB/CMSSW_15_1_X/master May 29, 2025
8 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the llvm-tool-cleanup branch May 29, 2025 17:54
@iarspider
Copy link
Contributor

iarspider commented May 30, 2025

@smuzaffar I think this change this breaks clang-tidy: https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_aarch64_gcc12/CMSSW_15_1_X_2025-05-29-2300/unitTestLogs/FWCore/Skeletons#/664-664

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 30, 2025

looking in to it

@smuzaffar
Copy link
Contributor Author

smuzaffar commented May 30, 2025

#9900 should fix this issue. Though the unit test will still fail in the PR tests of #9900 ( as tests createa developer area with old build rules) but one its merged then test should pass in the IBs and future PR tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-approved fully-signed orp-pending tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smuzaffar @cmsbuild @iarspider