ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

smuzaffar · 2025-05-27T13:23:55Z

Set HIP_PATH to point to ROCM installation.
Save --gcc-toolchain and --target in rocm/llvm/bin/clang++.cfg so that hipcc use the correct gcc header. This should fix the errors like [a] which we get for CLANG_X IBs

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/build-any-ib/CMSSW_15_1_CLANG_X_2025-05-26-2300/el8_amd64_gcc12/210560/external/mpich/v4.3.0-c040835408ff8a8ea619ea18241c5d7d/log

/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/rocm/6.3.2-7a3def4b63757b1f9ab69ba8ae027e92/lib/llvm/lib/clang/18/include/cuda_wrappers/cmath:27:15: fatal error: 'cmath' file not found
   27 | #include_next <cmath>

smuzaffar · 2025-05-27T13:24:04Z

please test

cmsbuild · 2025-05-27T13:24:21Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-05-27T13:24:21Z

cms-bot internal usage

smuzaffar · 2025-05-27T13:24:24Z

please test for CMSSW_15_1_CLANG_X

cmsbuild · 2025-05-27T13:48:06Z

Pull request #9893 was updated.

smuzaffar · 2025-05-27T13:48:34Z

please test

smuzaffar · 2025-05-27T13:48:45Z

please test for CMSSW_15_1_CLANG_X

cmsbuild · 2025-05-27T14:32:18Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46384/summary.html
COMMIT: f06c0e8
CMSSW: CMSSW_15_1_CLANG_X_2025-05-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9893/46384/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

-- Installing: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/542440a5dd643ed00b5989044bd41906/opt/cmssw/el8_amd64_gcc12/external/rocm/6.3.2-542440a5dd643ed00b5989044bd41906/share/rocprofiler-register/setup-env.sh
-- Installing: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/542440a5dd643ed00b5989044bd41906/opt/cmssw/el8_amd64_gcc12/external/rocm/6.3.2-542440a5dd643ed00b5989044bd41906/share/modulefiles/rocprofiler-register/0.4.0
-- Installing: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/542440a5dd643ed00b5989044bd41906/opt/cmssw/el8_amd64_gcc12/external/rocm/6.3.2-542440a5dd643ed00b5989044bd41906/lib/cmake/rocprofiler-register/rocprofiler-register-config.cmake
-- Installing: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/542440a5dd643ed00b5989044bd41906/opt/cmssw/el8_amd64_gcc12/external/rocm/6.3.2-542440a5dd643ed00b5989044bd41906/lib/cmake/rocprofiler-register/rocprofiler-register-config-version.cmake
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7LCB53: line 64: syntax error near unexpected token `<<<'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.7LCB53 (%install)


RPM build errors:
Macro expanded in comment on line 408: %{pkginstroot}

smuzaffar · 2025-05-27T14:36:35Z

please test for CMSSW_15_1_CLANG_X

smuzaffar · 2025-05-27T22:01:23Z

fixes clang IBs

cmsbuild · 2025-05-28T01:00:27Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46383/summary.html
COMMIT: f06c0e8
CMSSW: CMSSW_15_1_X_2025-05-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9893/46383/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46383/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46383/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test SagittaBiasNtuplizer had ERRORS

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4038164
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-05-28T05:44:39Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46388/summary.html
COMMIT: f06c0e8
CMSSW: CMSSW_15_1_CLANG_X_2025-05-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9893/46388/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46388/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093152/46388/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test SagittaBiasNtuplizer had ERRORS

Comparison Summary

Summary:

You potentially added 568 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 101601 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 571855
DQMHistoTests: Total nulls: 434
DQMHistoTests: Total successes: 3465884
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2.3190000000000004 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -2.183 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 141.042 ): -0.023 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.014 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.104 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.202 ): -0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.301,... ): -0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.5 ): 0.027 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.604 ): 0.055 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 145.713 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 17034.0 ): ...
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: found differences in 20 / 48 workflows

fwyzard · 2025-05-28T08:09:01Z

@smuzaffar does this mean that we can drop --target=@COMPILER_HOST@ --gcc-toolchain=$(COMPILER_PATH) from the ROCM_FLAGS in rocm.xml ?

smuzaffar · 2025-05-28T08:18:25Z

@fwyzard , I am testing that locally to see if we can drop it.

smuzaffar · 2025-05-28T08:57:31Z

looks like we can drop --target=@COMPILER_HOST@ --gcc-toolchain=$(COMPILER_PATH) from the tool file. I am opening a PR to remove these from rocm.xml

fwyzard · 2025-05-28T09:25:06Z

Thanks :)

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels May 27, 2025

rocm: set HIP_PATH and create clang++.cfg for gcc-toolchain

f06c0e8

smuzaffar force-pushed the mpich-clang-fix branch from 93c700d to f06c0e8 Compare May 27, 2025 13:47

cmsbuild added tests-pending and removed tests-started labels May 27, 2025

smuzaffar changed the title ~~Fixes for mpich~~ ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target May 27, 2025

cmsbuild added tests-started and removed tests-pending labels May 27, 2025

smuzaffar merged commit 80f6b5d into IB/CMSSW_15_1_X/master May 27, 2025
8 of 11 checks passed

cmsbuild added tests-rejected and removed tests-started labels May 28, 2025

smuzaffar mentioned this pull request May 28, 2025

ROCM: do not set --gcc-toolchain/--target via toolfile #9895

Merged

smuzaffar deleted the mpich-clang-fix branch May 29, 2025 17:54

ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

ROCM: set HIP_PATH and created clang++.cfg to provide gcc-toolchain and target #9893

Uh oh!

Conversation

smuzaffar commented May 27, 2025

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

cmsbuild commented May 27, 2025

Uh oh!

cmsbuild commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

cmsbuild commented May 27, 2025

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

cmsbuild commented May 27, 2025

External Build

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

smuzaffar commented May 27, 2025

Uh oh!

Uh oh!

cmsbuild commented May 28, 2025

Unit Tests

Comparison Summary

Uh oh!

cmsbuild commented May 28, 2025

Unit Tests

Comparison Summary

Uh oh!

fwyzard commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

smuzaffar commented May 28, 2025

Uh oh!

fwyzard commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented May 27, 2025 •

edited

Loading