Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 22, 2025

Build librocprofiler-register.so from sources instead of using the library from the RPM package.

fixes #9493

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

This PR replaces #9631.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2025

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

test parameters:

  • full_cmssw = true
  • enable_tests = gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

please test for CMSSW_15_0_NONLTO_X

@smuzaffar
Copy link
Contributor

@fwyzard , can you please also include fwyzard#2 changes?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

please abort

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

sorry, I missed it, I will add them here

@fwyzard fwyzard force-pushed the IB/CMSSW_15_0_X/master_build_rocprofiler-register branch from 1a022a4 to d123751 Compare January 22, 2025 09:37
@cmsbuild
Copy link
Contributor

Pull request #9632 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

please test for CMSSW_15_0_NONLTO_X

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1355d0/43909/summary.html
COMMIT: d123751
CMSSW: CMSSW_15_0_X_2025-01-21-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9632/43909/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+external

Build (which was failing before) passed.

@smuzaffar smuzaffar merged commit a71fbf6 into cms-sw:IB/CMSSW_15_0_X/master Jan 22, 2025
18 of 20 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1355d0/43908/summary.html
COMMIT: d123751
CMSSW: CMSSW_15_0_NONLTO_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9632/43908/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1355d0/43908/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1355d0/43908/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 52 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 78143 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 385302
  • DQMHistoTests: Total nulls: 312
  • DQMHistoTests: Total successes: 3433451
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.081 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 1.550 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 145.5 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.317 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.691 KiB SiStrip/MechanicalView
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 17 / 47 workflows

@fwyzard fwyzard deleted the IB/CMSSW_15_0_X/master_build_rocprofiler-register branch February 2, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ROCm] rocprofiler-register stub library

3 participants