Build ROCm rocprofiler-register from sources #9631

fwyzard · 2025-01-21T22:13:49Z

Build librocprofiler-register.so from sources instead of using the library from the RPM package.

Other minor changes:

remove deprecated links
drop support for RHEL 7

fwyzard · 2025-01-21T22:13:58Z

enable gpu

fwyzard · 2025-01-21T22:14:03Z

please test

cmsbuild · 2025-01-21T22:14:13Z

A new Pull Request was created by @fwyzard for branch IB/CMSSW_15_0_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-01-21T22:14:14Z

cms-bot internal usage

fwyzard · 2025-01-21T22:14:14Z

please test for CMSSW_15_0_NONLTO_X

cmsbuild · 2025-01-21T22:27:00Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43894/summary.html
COMMIT: d42284c
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43894/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

cmsbuild · 2025-01-21T22:28:15Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43895/summary.html
COMMIT: d42284c
CMSSW: CMSSW_15_0_NONLTO_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43895/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

fwyzard · 2025-01-21T22:52:18Z

Typo :-(

fwyzard · 2025-01-21T22:52:28Z

please test for CMSSW_15_0_NONLTO_X

cmsbuild · 2025-01-21T22:52:33Z

Pull request #9631 was updated.

fwyzard · 2025-01-21T22:53:16Z

please test

cmsbuild · 2025-01-21T23:07:40Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43896/summary.html
COMMIT: 42b27d4
CMSSW: CMSSW_15_0_NONLTO_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43896/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

cmsbuild · 2025-01-21T23:07:41Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43897/summary.html
COMMIT: 42b27d4
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43897/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

fwyzard · 2025-01-21T23:26:47Z

please test for CMSSW_15_0_NONLTO_X

cmsbuild · 2025-01-21T23:26:55Z

Pull request #9631 was updated.

fwyzard · 2025-01-21T23:27:49Z

please test

smuzaffar · 2025-01-22T08:17:44Z

drop support for RHEL 7

We still have el7 IBs, we can drop rocm dependency for el7 if that is what you want here

fwyzard · 2025-01-22T09:11:38Z

Ah, I thought we had dropped it.
I'll add back support for RHEL 7.

fwyzard · 2025-01-22T09:16:17Z

#9632 is the same as this PR, without dropping support for RHEL 7.
I opened a separate one to let the tests here complete.

cmsbuild · 2025-01-22T12:04:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43899/summary.html
COMMIT: 216ed99
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43899/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43899/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43899/git-merge-result

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3819085
DQMHistoTests: Total failures: 702
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3818363
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 24 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53071
DQMHistoTests: Total failures: 868
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 52203
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-01-22T13:33:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43898/summary.html
COMMIT: 216ed99
CMSSW: CMSSW_15_0_NONLTO_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9631/43898/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43898/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fb434/43898/git-merge-result

Comparison Summary

Summary:

You potentially added 122 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 78145 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3819085
DQMHistoTests: Total failures: 385304
DQMHistoTests: Total nulls: 312
DQMHistoTests: Total successes: 3433449
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3.081 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 1.550 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 145.5 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.317 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 1.691 KiB SiStrip/MechanicalView
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: found differences in 17 / 47 workflows

fwyzard · 2025-01-22T13:37:37Z

@smuzaffar the tests here are fine, OK to close this PR and keep #9632 ?

smuzaffar · 2025-01-22T13:43:08Z

@smuzaffar the tests here are fine, OK to close this PR and keep #9632 ?

yes

fwyzard · 2025-01-22T13:58:36Z

Superseded by #9632.

fwyzard added 2 commits January 21, 2025 22:59

Remove ROCm deprecated libraries

1c9d0f9

Remove ROCm support for RHEL 7

e3ecae0

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels Jan 21, 2025

fwyzard mentioned this pull request Jan 21, 2025

Multiple failures in NONLTO, CLANG and ASAN Unit Tests and RelVals due to PluginNotFound cms-sw/cmssw#44821

Closed

cmsbuild added tests-rejected and removed tests-started labels Jan 21, 2025

fwyzard force-pushed the IB/CMSSW_15_0_X/master_update_ROCm branch from d42284c to 42b27d4 Compare January 21, 2025 22:52

cmsbuild added tests-started and removed tests-rejected labels Jan 21, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 21, 2025

Build ROCm rocprofiler-register from sources

216ed99

fwyzard force-pushed the IB/CMSSW_15_0_X/master_update_ROCm branch from 42b27d4 to 216ed99 Compare January 21, 2025 23:26

cmsbuild added tests-started and removed tests-rejected labels Jan 21, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 22, 2025

fwyzard mentioned this pull request Jan 22, 2025

Build ROCm rocprofiler-register from sources #9632

Merged

fwyzard closed this Jan 22, 2025

fwyzard deleted the IB/CMSSW_15_0_X/master_update_ROCm branch January 22, 2025 13:58

Build ROCm rocprofiler-register from sources #9631

Build ROCm rocprofiler-register from sources #9631

Uh oh!

Conversation

fwyzard commented Jan 21, 2025

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025

External Build

Uh oh!

cmsbuild commented Jan 21, 2025

External Build

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025

External Build

Uh oh!

cmsbuild commented Jan 21, 2025

External Build

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

cmsbuild commented Jan 21, 2025

Uh oh!

fwyzard commented Jan 21, 2025

Uh oh!

smuzaffar commented Jan 22, 2025

Uh oh!

fwyzard commented Jan 22, 2025

Uh oh!

fwyzard commented Jan 22, 2025

Uh oh!

cmsbuild commented Jan 22, 2025

Comparison Summary

GPU Comparison Summary

Uh oh!

cmsbuild commented Jan 22, 2025

Comparison Summary

Uh oh!

fwyzard commented Jan 22, 2025

Uh oh!

smuzaffar commented Jan 22, 2025

Uh oh!

fwyzard commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Jan 21, 2025 •

edited

Loading