-
Notifications
You must be signed in to change notification settings - Fork 207
Improve protobuf text_format output #8947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve protobuf text_format output #8947
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_14_0_X/master. @smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
|
Pull request #8947 was updated. |
|
please test with cms-sw/cmssw#43696 |
|
-1 Failed Tests: UnitTests RelVals-INPUT Unit TestsI found 1 errors in the following unit tests: ---> test testAlcaBeamMonitor had ERRORS RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test testAlcaBeamMonitor had ERRORS Comparison SummarySummary:
|
This PR applies a small patch to protobuf so that text output from the
text_formatPython API avoids repetition for both primitive types and message types. This is used to get more concise printouts from thecmsTritonConfigTool(see cms-sw/cmssw#43695 and cms-sw/cmssw#43696).