Skip to content

[json] Version 3.11.3; build with cmake #8911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smuzaffar merged 2 commits into from
Dec 23, 2023
Merged

[json] Version 3.11.3; build with cmake #8911

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be27ff6
[json] Version 3.11.3; build with cmake
smuzaffar Dec 23, 2023
5b63deb
set JSON_BuildTests=OFF
smuzaffar Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions json.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
### RPM external json 3.10.2
### RPM external json 3.11.3
## NOCOMPILER

Source: https://github.com/nlohmann/%{n}/releases/download/v%{realversion}/include.zip
Source: https://github.com/nlohmann/json/archive/refs/tags/v%{realversion}.tar.gz

%prep
%setup -c
%setup -n %{n}-%{realversion}
sed -i -e 's|JSON_BuildTests_INIT ON|JSON_BuildTests_INIT OFF|' CMakeLists.txt
Copy link
Contributor

@sethrj sethrj Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just add -DJSON_BuildTests=OFF to the cmake line for the same effect (but more robust against future changes)

Copy link
Contributor Author

@smuzaffar smuzaffar Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sethrj


%build
rm -rf ../build; mkdir ../build; cd ../build
cmake ../%{n}-%{realversion} \
-DCMAKE_INSTALL_PREFIX:PATH="%i" \
-DCMAKE_BUILD_TYPE=%{cmake_build_type} \
-DJSON_MultipleHeaders=OFF

%install
mkdir -p %{i}/include/nlohmann
cp -a include/nlohmann/json_fwd.hpp %{i}/include/nlohmann/
cp -a single_include/nlohmann/json.hpp %{i}/include/nlohmann/
make %makeprocesses VERBOSE=1

%post
%install
cd ../build
make install