-
Notifications
You must be signed in to change notification settings - Fork 206
[json] Version 3.11.3; build with cmake #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
json.spec
Outdated
| %prep | ||
| %setup -c | ||
| %setup -n %{n}-%{realversion} | ||
| sed -i -e 's|JSON_BuildTests_INIT ON|JSON_BuildTests_INIT OFF|' CMakeLists.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just add -DJSON_BuildTests=OFF to the cmake line for the same effect (but more robust against future changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sethrj
|
Pull request #8911 was updated. |
|
please test |
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1c32/36667/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Building with cmake allows other cmake based projects to find our installation