Skip to content

Conversation

@raoatifshad
Copy link

Updated the geant4 version 11.4.0
updated the dataset PhotonEvaporation-6.1.2

@raoatifshad
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2025

A new Pull Request was created by @raoatifshad for branch IB/CMSSW_16_0_X/g4.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2025

cms-bot internal usage

@raoatifshad
Copy link
Author

please test

@iarspider
Copy link
Contributor

please test for CMSSW_16_0_GEANT4_X

@iarspider
Copy link
Contributor

please test for CMSSW_16_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2025

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49831/summary.html
COMMIT: bd6955e
CMSSW: CMSSW_16_0_GEANT4_X_2025-12-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10243/49831/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49831/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49831/git-merge-result

Failed Unit Tests

I found 11 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test trackerMaterialAnalysisPlots had ERRORS
and more ...

Failed RelVals

The relvals timed out after 4 hours.

Failed AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2025

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49832/summary.html
COMMIT: bd6955e
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-12-03-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10243/49832/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49832/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49832/git-merge-result

Failed Unit Tests

I found 11 errors in the following unit tests:

---> test materialBudgetHGCalPlots had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test testTauEmbeddingWorkflow2016postVFP had ERRORS
and more ...

Failed RelVals

The relvals timed out after 4 hours.

Failed AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@iarspider
Copy link
Contributor

Unit tests have timed out. I have restarted tests job for G4, let's see if the issue persists.

@iarspider
Copy link
Contributor

Yes, the issue persists. @civanch FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49848/summary.html
COMMIT: bd6955e
CMSSW: CMSSW_16_0_GEANT4_X_2025-12-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10243/49848/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49848/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49848/git-merge-result

Failed Unit Tests

I found 11 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test trackerMaterialAnalysisPlots had ERRORS
and more ...

Failed RelVals

The relvals timed out after 4 hours.

Failed AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@smuzaffar
Copy link
Contributor

please test for CMSSW_16_0_G4VECGEOM_X

lets see if full cmssw works

@kpedro88
Copy link
Contributor

@civanch can you provide the relevant code change in patch format? then it can be automatically applied to the official source code by our build system

@civanch
Copy link
Contributor

civanch commented Dec 13, 2025

@kpedro88 , you are right. may be we will do that if will not find out a solution for unit tests.

@smuzaffar
Copy link
Contributor

@civanch , Can you please open a PR against https://github.com/cms-externals/geant4/tree/cms/v11.4.0 for your fix/change?

@civanch
Copy link
Contributor

civanch commented Dec 13, 2025

@smuzaffar , will do.

@civanch
Copy link
Contributor

civanch commented Dec 13, 2025

@iarspider , @smuzaffar , PR cms-externals/geant4#101 is done

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with cms-externals/geant4#101, please check if they should be merged together

@cmsbuild
Copy link
Contributor

Pull request #10243 was updated.

@smuzaffar
Copy link
Contributor

please test for CMSSW_16_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49989/summary.html
COMMIT: 161e099
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-12-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10243/49989/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49989/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/49989/git-merge-result

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS
---> test unitTestsGroup_1_u2 had ERRORS
---> test unitTestsGroup_4_u20 had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 259 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 65526 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4271963
  • DQMHistoTests: Total failures: 383589
  • DQMHistoTests: Total nulls: 440
  • DQMHistoTests: Total successes: 3887914
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42688.78200000001 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 13034.0 ): -1.124 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 17034.0 ): 1.054 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18634.0 ): 1.939 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.188 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 34434.0,... ): 3336.274 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 34434.0 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 19 / 51 workflows

@smuzaffar
Copy link
Contributor

please test for CMSSW_16_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/50001/summary.html
COMMIT: 161e099
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-12-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10243/50001/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/50001/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9915f9/50001/git-merge-result

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS
---> test unitTestsGroup_1_u2 had ERRORS
---> test unitTestsGroup_4_u20 had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 259 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 65526 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4271963
  • DQMHistoTests: Total failures: 383587
  • DQMHistoTests: Total nulls: 440
  • DQMHistoTests: Total successes: 3887916
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42688.78200000001 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 13034.0 ): -1.124 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 17034.0 ): 1.054 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18634.0 ): 1.939 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.188 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 34434.0,... ): 3336.274 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 34434.0 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 19 / 51 workflows

@smuzaffar
Copy link
Contributor

+externals

unit test failures are not due to this change

@smuzaffar smuzaffar merged commit 17162c0 into cms-sw:IB/CMSSW_16_0_X/g4 Dec 17, 2025
8 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/g4 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants