Skip to content

Conversation

@civanch
Copy link
Contributor

@civanch civanch commented Dec 13, 2025

CMS unit tests crash if the default value of the parallel initialization flag is used. This PR fix the issue.

@cmsbuild
Copy link

A new Pull Request was created by @civanch for branch cms/v11.4.0.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Dec 13, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor

thanks @civanch , so this is not to fix the hanging tests? Note that relvals/addon and unit tests still hangs for Geant4 11.4 cms-sw/cmssw#49615 (comment) ( even with your fix in cmssw : cms-sw/cmssw#49615)

@civanch
Copy link
Contributor Author

civanch commented Dec 13, 2025

@smuzaffar , if we exclude cms-sw/cmssw#49615?

@smuzaffar
Copy link
Contributor

please test for CMSSW_16_0_GEANT4_X

lets tests it without cms-sw/cmssw#49615

@smuzaffar
Copy link
Contributor

please test for CMSSW_16_0_G4VECGEOM_X

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#10243 for CMSSW_16_0_GEANT4_X

@civanch , looks like tests did not hang without cms-sw/cmssw#49615. Let me re-run the tests with cmsdist PR which also has new geant4 data

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/summary.html
COMMIT: 7de8992
CMSSW: CMSSW_16_0_GEANT4_X_2025-12-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/101/49978/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/git-merge-result

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49976/summary.html
COMMIT: 7de8992
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-12-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/101/49976/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49976/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49976/git-merge-result

Comparison Summary

Summary:

  • You potentially added 232 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 65873 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4271963
  • DQMHistoTests: Total failures: 382519
  • DQMHistoTests: Total nulls: 445
  • DQMHistoTests: Total successes: 3888979
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42689.28500000001 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -2.818 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 17034.0 ): 0.468 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18634.0 ): 2.291 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.240 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.161 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 34434.0 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 19 / 51 workflows

@smuzaffar
Copy link
Contributor

+externals

thesis for special Geant4 IBs

@smuzaffar smuzaffar merged commit 52ac4a8 into cms-externals:cms/v11.4.0 Dec 15, 2025
14 checks passed
@cmsbuild
Copy link

This pull request is fully signed and it will be integrated in one of the next cms/v11.4.0 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10243

smuzaffar added a commit to raoatifshad/cmsdist that referenced this pull request Dec 15, 2025
@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/summary.html
COMMIT: 7de8992
CMSSW: CMSSW_16_0_GEANT4_X_2025-12-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/101/49978/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d74/49978/git-merge-result

Comparison Summary

Summary:

  • You potentially added 264 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66539 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4271963
  • DQMHistoTests: Total failures: 373432
  • DQMHistoTests: Total nulls: 461
  • DQMHistoTests: Total successes: 3898050
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42692.26800000001 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 10224.0 ): -0.371 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 17034.0 ): 1.068 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18634.0 ): 0.674 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.240 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 34434.0,... ): 3336.274 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 34434.0 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 17 / 51 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants