Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 17, 2025

Introduce the xtd::arithmetic concept.
Implement the xtd::min, xtd::max, and xtd::clamp functions and their tests.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 17, 2025

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 17, 2025

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efc97f/49497/summary.html
COMMIT: f9b1e0c
CMSSW: CMSSW_16_0_X_2025-11-16-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10203/49497/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efc97f/49497/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-efc97f/49497/git-merge-result

Comparison Summary

Summary:

  • You potentially added 62 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3896448
  • DQMHistoTests: Total failures: 15321
  • DQMHistoTests: Total nulls: 10
  • DQMHistoTests: Total successes: 3881097
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 4 / 49 workflows

AMD_MI300X Comparison Summary

Summary:

  • You potentially added 36 lines to the logs
  • Reco comparison results: 234 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148553
  • DQMHistoTests: Total failures: 38491
  • DQMHistoTests: Total nulls: 23
  • DQMHistoTests: Total successes: 110039
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 4 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

  • You potentially added 35 lines to the logs
  • Reco comparison results: 231 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148553
  • DQMHistoTests: Total failures: 47054
  • DQMHistoTests: Total nulls: 25
  • DQMHistoTests: Total successes: 101474
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 4 / 10 workflows

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 235 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148553
  • DQMHistoTests: Total failures: 37855
  • DQMHistoTests: Total nulls: 26
  • DQMHistoTests: Total successes: 110672
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 5 / 10 workflows

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially added 39 lines to the logs
  • Reco comparison results: 262 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148553
  • DQMHistoTests: Total failures: 38390
  • DQMHistoTests: Total nulls: 25
  • DQMHistoTests: Total successes: 110138
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 5 / 10 workflows

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially added 48 lines to the logs
  • Reco comparison results: 246 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148553
  • DQMHistoTests: Total failures: 38508
  • DQMHistoTests: Total nulls: 27
  • DQMHistoTests: Total successes: 110018
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 6 / 10 workflows

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 87348eb into cms-sw:IB/CMSSW_16_0_X/master Nov 17, 2025
23 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants