Skip to content

Conversation

@smuzaffar
Copy link
Contributor

backport of #10206

Backport is from G4ADEPT IBs in to Geant4 special IBs

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 19, 2025

please test for CMSSW_16_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2025

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_0_X/g4.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7caffd/49553/summary.html
COMMIT: ffcd75e
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-11-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10210/49553/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7caffd/49553/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7caffd/49553/git-merge-result

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially added 454 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 62485 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3896448
  • DQMHistoTests: Total failures: 491978
  • DQMHistoTests: Total nulls: 286
  • DQMHistoTests: Total successes: 3404164
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7.088999999999999 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -4.380 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): 4.442 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -5.771 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -0.778 KiB SiStrip/MechanicalView
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 16 / 49 workflows

@smuzaffar
Copy link
Contributor Author

+externals

good to go in special Geant4 IBs

@smuzaffar smuzaffar merged commit e8b457e into IB/CMSSW_16_0_X/g4 Nov 20, 2025
7 of 8 checks passed
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch November 20, 2025 07:24
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/g4 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants