Build ROOT with the external version of Nlohmann Json #10161
Conversation
fwyzard
changed the title
|
type bugfix |
|
A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
please test |
|
cms-bot internal usage |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff801b/49133/summary.html Failed External BuildI found compilation error when building: cmake/modules/SearchInstalledSoftware.cmake:74 (find_package)
CMakeLists.txt:298 (include)
-- Configuring incomplete, errors occurred!
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Ik644z (%build)
RPM build warnings:
Macro expanded in comment on line 404: %{pkginstroot}/lib
Macro expanded in comment on line 405: %{pkginstroot}
|
fwyzard
force-pushed
the
IB/CMSSW_16_0_X/master_root_external_json
branch
from
5694103 to
6377187
Compare
|
please test |
|
Pull request #10161 was updated. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff801b/49134/summary.html Failed External BuildI found compilation error when building: -- Executables will be linked against CepGen -- Utilities will be built -- Found Doxygen: /usr/bin/doxygen (found version "1.8.14") found components: doxygen missing components: dot -- Doxygen found -- Configuring incomplete, errors occurred! error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.pGNBdO (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.pGNBdO (%build) * The action "install-external+cepgen+1.2.5-af3160cde41b6bbb1883205b9ad3f450" was not completed successfully because The following dependencies could not complete: |
fwyzard
force-pushed
the
IB/CMSSW_16_0_X/master_root_external_json
branch
from
6377187 to
acc0945
Compare
|
Pull request #10161 was updated. |
|
please test |
|
please test with cms-sw/cmssw#49278 |
|
please test with cms-sw/cmssw#49278 for el9_amd64_gcc13 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff801b/49152/summary.html Comparison SummarySummary:
|
|
looks good but this should only go in after cms-sw/cmssw#49278 has been integrated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff801b/49153/summary.html Comparison SummarySummary:
|
|
@smuzaffar now that cms-sw/cmssw#49278 is merged, could we go ahead with this too ? |
|
please test lets build without cms-sw/cmssw#49278 to sure every thing works |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff801b/49256/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
3 participants
ROOT comes with Nlohmann Json v3.10, while other CMS externals use v3.11.
This may cause conflicts when building an external or CMS package that use both ROOT and Json, because the version being used depend on the order of the
-Iflags passed to the compiler.