Enable ROCm for el10 builds #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROCM version 7.0.2 and above are available for el10
Contributor
|
A new Pull Request was created by @smuzaffar for branch master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
Contributor
Author
|
please test for CMSSW_16_0_ROOT636_X/el10_amd64_gcc14 |
Contributor
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed BuildI found compilation error when building: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el10_amd64_gcc14/external/gcc/14.3.1-724da22786638848892aa9ded8fcd995/bin/ar crs tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/libtestRocmSoALayoutAndView_t_rocm.a tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/SoALayoutAndView_t.hip.cc.o.rocm_o >> Building binary testRocmSoALayoutAndView_t /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el10_amd64_gcc14/external/rocm/7.0.2-eab50e019c80298518960b60a80a049f/bin/hipcc --offload-arch=gfx908:sramecc+ --offload-arch=gfx90a:sramecc+ --offload-arch=gfx942:sramecc+ --offload-arch=gfx1030 --offload-arch=gfx1100 --offload-arch=gfx1102 -fgpu-rdc -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-unknown-warning-option -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -Wno-tautological-type-limit-compare -Wno-vla-cxx-extension -fsized-deallocation -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fPIC tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/SoALayoutAndView_t.hip.cc.o -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/biglib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/lib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/external/el10_amd64_gcc14/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/biglib/el10_amd64_gcc14 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/lib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/static/el10_amd64_gcc14 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/static/el10_amd64_gcc14 -lboost_thread -lboost_date_time -lamdhip64 -lhsa-runtime64 -lrocm_smi64 -lfmt -lcrypt -ldl -lrt -o tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/testRocmSoALayoutAndView_t /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el10_amd64_gcc14/external/gcc/14.3.1-724da22786638848892aa9ded8fcd995/lib/gcc/x86_64-vendor-linux/14.3.1/../../../../x86_64-vendor-linux/bin/ld.bfd: tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/SoALayoutAndView_t-713fbc.o: in function `main': SoALayoutAndView_t.hip.cc:(.text+0x1c2): undefined reference to `cms::rocmtest::requireDevices()' clang++: error: linker command failed with exit code 1 (use -v to see invocation) failed to execute:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el10_amd64_gcc14/external/rocm/7.0.2-eab50e019c80298518960b60a80a049f/lib/llvm/bin/clang++ --driver-mode=g++ --hip-link --offload-arch=gfx908:sramecc+ --offload-arch=gfx90a:sramecc+ --offload-arch=gfx942:sramecc+ --offload-arch=gfx1030 --offload-arch=gfx1100 --offload-arch=gfx1102 -fgpu-rdc -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-unknown-warning-option -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -Wno-tautological-type-limit-compare -Wno-vla-cxx-extension -fsized-deallocation -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fPIC tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/SoALayoutAndView_t.hip.cc.o -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/biglib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/lib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/external/el10_amd64_gcc14/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/biglib/el10_amd64_gcc14 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/lib/el10_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_ROOT636_X_2025-11-04-1100/static/el10_amd64_gcc14 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02914/el10_amd64_gcc14/cms/cmssw/CMSSW_16_0_ROOT636_X_2025-11-04-1100/static/el10_amd64_gcc14 -lboost_thread -lboost_date_time -lamdhip64 -lhsa-runtime64 -lrocm_smi64 -lfmt -lcrypt -ldl -lrt -o "tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/testRocmSoALayoutAndView_t" >> Deleted: tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/testRocmSoALayoutAndView_t gmake: *** [tmp/el10_amd64_gcc14/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/testRocmSoALayoutAndView_t] Error 1 Entering library rule at src/DataFormats/SoATemplate/test >> Building LCG reflex dict from header file src/DataFormats/SoATemplate/test/classes.h |
Contributor
Author
|
please test for CMSSW_16_0_ROOT636_X/el10_amd64_gcc14 |
Contributor
Author
|
please test for CMSSW_16_0_ROOT636_X/el10_amd64_gcc14 using full CMSSW |
Contributor
Author
|
abort |
Contributor
Author
|
please test with cms-sw/cmsdist#10182 for CMSSW_16_0_ROOT636_X/el10_amd64_gcc14 using full CMSSW |
Contributor
Author
|
please test for CMSSW_16_0_PY312_X |
Contributor
Author
|
+externals el10 build with ROCm went fine |
cmsbuild
added
fully-signed
externals-approved
and removed
pending-signatures
externals-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 6 errors in the following unit tests: ---> test TestConfigDP_12 had ERRORS ---> test TestConfigDP_2 had ERRORS ---> test TestConfigDP_5 had ERRORS and more ... Comparison SummarySummary:
|
Contributor
|
-1 Failed Tests: AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed AddOn TestsExpand to see more addon errors ...Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROCM version 7.0.2 and above are available for el10