-
Notifications
You must be signed in to change notification settings - Fork 264
enable dqm comparison job for rntuple #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
enable rntuple |
|
A new Pull Request was created by @smuzaffar for branch master. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test though RNTuple comparison job will fail but lets see what works |
|
Pull request #2651 was updated. |
6 similar comments
|
Pull request #2651 was updated. |
|
Pull request #2651 was updated. |
|
Pull request #2651 was updated. |
|
Pull request #2651 was updated. |
|
Pull request #2651 was updated. |
|
Pull request #2651 was updated. |
|
please test |
|
-1 Failed Tests: RelVals-RNTUPLE Failed RelVals-RNTUPLE
Comparison SummarySummary:
RNTUPLE Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 132 workflow step(s) with memory usage exceeding the error threshold:
|
|
(not related to this PR)
I assume this report is for comparing RNTuple RelVals to default RelVals. Large increase is presently expected, but maybe there is some value in keeping them and recording the values in GitHub comments? If the default RelVals would issue a warning as well, would we have two Couple of further notes: It would be nice if the order of workflows in the summary message #2651 (comment) would be the same as in the tables https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsRNTUPLE/CMSSW_16_1_X_2026-01-15-1100+96a0b5/72771/maxmem-comparison/maxmem_summary.html In the summary page https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96a0b5/50657/summary.html I see
@gartung Would you be able look into polishing these aspects? (we should open a separate task issue for the work) |
I think the order is determined by when the tests complete so it is not deterministic. RNTUPLE is a flavor of test and might have completed first. |
|
It might be alphabetical order in which case 2653 should fix it. |
@makortel , yes this is for RNTuple Relvals comparison with default IBs relvals (non-rntuple). I personally think that we should only have a short message e.g.
yes, each comparison job will add an extra Max Memory Comparison section. For now we are running comparison for default and rntuple only but if in future we enabled it for GPUs then each GPU can add this section. @gartung , order of the items on the summary page is alphabetical, so if you change these items to start with |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96a0b5/50703/summary.html Comparison SummarySummary:
RNTUPLE Comparison SummarySummary:
Max Memory Comparisons exceeding threshold RNTUPLE@cms-sw/core-l2 , I found 134 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
Pull request #2651 was updated. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96a0b5/50705/summary.html Comparison SummarySummary:
RNTUPLE Comparison SummarySummary:
Max Memory Comparisons exceeding threshold RNTUPLE@cms-sw/core-l2 , I found 133 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
please test with cms-sw/cmsdist#10212 |
|
-1 Failed Tests: UnitTests RelVals-RNTUPLE The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 1 errors in the following unit tests: ---> test testDiMuonBiasesPlotting had ERRORS Failed RelVals-RNTUPLEThe relvals timed out after 4 hours. Comparison SummarySummary:
|
|
@makortel , should I kill the hanging jobs to let the comparison job finish (and have the build node used by other jobs) or you still want to debug more? I can restart the job tomorrow if needed? |
|
Feel free to kill them (sorry, I could have said that earlier). |
|
-1 Failed Tests: UnitTests RelVals-RNTUPLE The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 1 errors in the following unit tests: ---> test testDiMuonBiasesPlotting had ERRORS Failed RelVals-RNTUPLEThe relvals timed out after 4 hours. Comparison SummarySummary:
RNTUPLE Comparison SummarySummary:
|

This change enables running PR DQM/Reco comparison for RNTuple tests.