-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Speed up reading *Auxiliary fields in RNTupleTempSource
#49902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Speeded up the initial read of EventAuxiliary field for a file with 2.5M tiny events from 6.6 hours to about a second.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49902/47636 |
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
@gartung @smuzaffar The max memory report does not seem to be reported for RNTuple presently. Is that expected? |
|
+1 |
@makortel , as cms-sw/cms-bot#2651 is not yet merged (which enables rntuple tests comparison) so that is why you dop not see max memory comparsion results for rntuple . We need to fix the issue of hanging edm tools before enabling the runtuple PR comparsion |
|
Ok, thanks for the clarification! |


PR description:
In the context of #48400 (but not as full resolution) this PR speeds up the initial reading of the
*Auxiliaryfields. With the input file in #48400 that had 2.5M tiny events, the initial read ofEventAuxiliarywent from 6.6 hours to ~1 second.Resolves cms-sw/framework-team#1785
PR validation:
Workflow 139.005 step3 starts much faster.