Skip to content

Do not process closed PRs #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smuzaffar merged 5 commits into from
Apr 11, 2025
Merged

Do not process closed PRs #2471

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5ff616
Do not trigger tests for closed PRs
iarspider Apr 8, 2025
abb47db
Do not create status if PR is not open and there is no existing status
iarspider Apr 9, 2025
58d021f
Changes from review
iarspider Apr 11, 2025
84db007
Do not change labels if not creating status
iarspider Apr 11, 2025
2677e37
Do not change 'tests' labels if PR is closed and doesn't have status
iarspider Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions process_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,20 @@ def setup_logging(loglevel):
logger.addHandler(handler)


from github import Commit

create_status = True
original__create_status = Commit.Commit.create_status


def my_create_status(*args, **kwargs):
if create_status:
original__create_status(*args, **kwargs)


Commit.Commit.create_status = my_create_status


def update_CMSSW_LABELS(repo_config):
try:
check_dpg_pog = repo_config.CHECK_DPG_POG
Expand Down Expand Up @@ -927,7 +941,7 @@ def ensure_ascii(string):


def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=False):
global L2_DATA
global L2_DATA, create_status
if (not force) and ignore_issue(repo_config, repo, issue):
return

Expand Down Expand Up @@ -1079,6 +1093,9 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
except:
pass

if pr.state == "closed":
create_test_property = False

logger.info("Following packages affected: %s", ", ".join(packages))
for package in packages:
package_categories[package] = set([])
Expand Down Expand Up @@ -2007,6 +2024,9 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
# if not extra_labels[ltype]:
# del extra_labels[ltype]

if bot_status is None and issue.state != "open":
create_status = False

# Always set test pending label
if "tests" in signatures:
if test_comment is not None:
Expand Down Expand Up @@ -2279,6 +2299,11 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
labels.append("fully-signed-draft")
if need_external:
labels.append("requires-external")

if (not bot_status) and issue.state != "open":
labels = [l for l in labels if not l.startswith("tests-")]
labels.extend(l for l in old_labels if l.startswith("tests-"))

labels = set(labels)
logger.info("New Labels: %s", sorted(labels))

Expand Down Expand Up @@ -2330,7 +2355,7 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
add_labels = repo_config.ADD_LABELS
except:
pass
if add_labels:
if add_labels and create_status:
issue.edit(labels=list(labels))

if not issue.pull_request:
Expand Down