Do not process closed PRs

[iarspider]

@smuzaffar as discussed

[cmsbuild]

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[cmsbuild]

Pull request #2471 was updated.

[smuzaffar]

@iarspider , checking for bot_status has no use here. It might be empty for first run but on next bot run it will have some statuses . all of your current changes are not needed. A simple change like

if pr.state == "closed":
  create_test_property=False

after https://github.com/cms-sw/cms-bot/blob/master/process_pr.py#L1080 line will stop running PR tests for closed PRs.

I also wanted to avoid creating new statuses if PR is closed and old statuses are empty. It could be that there is bug on github side and they restore the old commit statuses at some point. If we create new statuses then they might not be able to restore them

[iarspider]

Ah, I see. I will now work on the second part of this PR (not updating statuses).

[cmsbuild]

Pull request #2471 was updated.

[cmsbuild]

Pull request #2471 was updated.

[smuzaffar]

instead of uses create_status flag everywhere, as discussed, please try to override the commit status creation function

[cmsbuild]

Pull request #2471 was updated.

[smuzaffar]

@iarspider , I have tested this for cms-sw/cmssw#40600 and it worked fine but it did change the label to test-started though it properly did not create the property file for test to start. Can we avoid changing test label too for such PRs?

[iarspider]

@smuzaffar so if we don't create status, we also don't change test labels, right? We do want to change other labels (e.g. x-approved)?

[smuzaffar]

@iarspider , not exactly. We will still allow to change labels ( e.g. when someone signs a already merged PR) but we should avoid changing test labels for closed PRs

[iarspider]

@iarspider , not exactly. We will still allow to change labels ( e.g. when someone signs a already merged PR) but we should avoid changing test labels for closed PRs

Understood.

[smuzaffar]

we should avoid changing test labels for closed PRs

@iarspider , Note that we do want bot to update the tests labels for PRs for which release managers has merged while tests are still running. So we should avoid changing test labels for closed PRs which also have no commit statuses .

[cmsbuild]

Pull request #2471 was updated.

[cmsbuild]

Pull request #2471 was updated.

[smuzaffar]

+externals

looks good, tested at cms-sw/cmssw#40598 and cms-sw/cmssw#40599 and bot did not set commit statuses or changed test labels

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)